From: "H. Peter Anvin" <hpa@zytor.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Marek Vasut <marex@denx.de>, Jianyu Zhan <nasa4836@gmail.com>,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions
Date: Thu, 17 Apr 2014 22:01:39 -0700 [thread overview]
Message-ID: <5350B1B3.9010902@zytor.com> (raw)
In-Reply-To: <20140418045828.GA31103@gondor.apana.org.au>
On 04/17/2014 09:58 PM, Herbert Xu wrote:
>>
>> It doesn't make sense, sorry. The right thing to drop here is not
>> "asmlinkage", it is "static": this is an external declaration.
>
> It's a function pointer that's static, not the function that
> it's pointing to.
>
{facepalm} Right, function *pointer*.
Duh.
-hpa
prev parent reply other threads:[~2014-04-18 5:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 16:19 [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions Jianyu Zhan
2014-04-17 15:28 ` Marek Vasut
2014-04-18 4:49 ` H. Peter Anvin
2014-04-18 4:58 ` Herbert Xu
2014-04-18 5:01 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5350B1B3.9010902@zytor.com \
--to=hpa@zytor.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mingo@redhat.com \
--cc=nasa4836@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox