From: Randy Dunlap <rdunlap@infradead.org>
To: Terence Eden <terence.eden@gmail.com>, vgupta@synopsys.com
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au,
kernel@shkspr.mobi, Terence Eden <github.com@shkspr.mobi>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] Fixed spelling errors within comments
Date: Sun, 20 Apr 2014 09:59:53 -0700 [thread overview]
Message-ID: <5353FD09.6000701@infradead.org> (raw)
In-Reply-To: <1397997228-2701-1-git-send-email-terence.eden@gmail.com>
On 04/20/2014 05:33 AM, Terence Eden wrote:
> From: Terence Eden <github.com@shkspr.mobi>
>
> This is my first patch submission. Please let me know if I have made a mistake anywhere.
>
> Signed-off-by: Terence Eden <github.com@shkspr.mobi>
trivial's email address is trivial@kernel.org (cc-ed).
> ---
> arch/arc/kernel/entry.S | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arc/kernel/entry.S b/arch/arc/kernel/entry.S
> index 819dd5f..38ef91a 100644
> --- a/arch/arc/kernel/entry.S
> +++ b/arch/arc/kernel/entry.S
> @@ -156,7 +156,7 @@ ARCFP_DATA int1_saved_reg
> int1_saved_reg:
> .zero 4
>
> -/* Each Interrupt level needs it's own scratch */
> +/* Each Interrupt level needs its own scratch */
> #ifdef CONFIG_ARC_COMPACT_IRQ_LEVELS
>
> ARCFP_DATA int2_saved_reg
> @@ -473,7 +473,7 @@ trap_with_param:
> lr r0, [efa]
> mov r1, sp
>
> - ; Now that we have read EFA, its safe to do "fake" rtie
> + ; Now that we have read EFA, it is safe to do "fake" rtie
> ; and get out of CPU exception mode
> FAKE_RET_FROM_EXCPN r11
>
> @@ -676,9 +676,9 @@ not_exception:
> brne r9, event_IRQ2, 149f
>
> ;------------------------------------------------------------------
> - ; if L2 IRQ interrupted a L1 ISR, we'd disbaled preemption earlier
> - ; so that sched doesnt move to new task, causing L1 to be delayed
> - ; undeterministically. Now that we've achieved that, lets reset
> + ; if L2 IRQ interrupted a L1 ISR, we'd disabled preemption earlier
I would write: an L1 ISR,
anyway:
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> + ; so that sched doesn't move to new task, causing L1 to be delayed
> + ; undeterministically. Now that we've achieved that, let's reset
> ; things to what they were, before returning from L2 context
> ;----------------------------------------------------------------
>
> @@ -734,7 +734,7 @@ ENTRY(ret_from_fork)
> ; put last task in scheduler queue
> bl @schedule_tail
>
> - ; If kernel thread, jump to it's entry-point
> + ; If kernel thread, jump to its entry-point
> ld r9, [sp, PT_status32]
> brne r9, 0, 1f
>
>
--
~Randy
next prev parent reply other threads:[~2014-04-20 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 12:33 [PATCH] Fixed spelling errors within comments Terence Eden
2014-04-20 16:59 ` Randy Dunlap [this message]
2014-04-21 5:24 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5353FD09.6000701@infradead.org \
--to=rdunlap@infradead.org \
--cc=github.com@shkspr.mobi \
--cc=kernel@shkspr.mobi \
--cc=linux-kernel@vger.kernel.org \
--cc=terence.eden@gmail.com \
--cc=trivial@kernel.org \
--cc=trivial@rustcorp.com.au \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox