From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753337AbcFOKkQ (ORCPT ); Wed, 15 Jun 2016 06:40:16 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:53585 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbcFOKkN (ORCPT ); Wed, 15 Jun 2016 06:40:13 -0400 From: Arnd Bergmann To: Andrey Smirnov Cc: linux-arm-kernel@lists.infradead.org, Russell King , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] i.MX: Do not explicitly call l2x0_of_init() Date: Wed, 15 Jun 2016 12:41:09 +0200 Message-ID: <5355653.147Wd29CCq@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1465954193-5894-7-git-send-email-andrew.smirnov@gmail.com> References: <1465954193-5894-1-git-send-email-andrew.smirnov@gmail.com> <1465954193-5894-7-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:+tGTv0v8T/Ggf5H6k3PmXQrmk1SVQ0jtOwPZmJB/0AnGPtlBXsk g+r3agzN/TaSdEck9D69w6SPQQsIwT10jz9D7I0QGE1LKiI3XbiFv0W+s8VZabKHlifTdSP qLhYyVAV61BN1CrhxmoxAoh1CVGsIqUTfD5uGX8rGo9KdysMwY41r7zEUzaAVl7yvQHt746 YbTiNRSnkvWwQ6zH2Evgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:NVEmqv/pc6s=:r+jxVk1Y1fbDMfgQ2zsPl/ yWZ/i3dYvymGPCr5niiYqrcUegAg0awiDQB1LRiEUUWAHjongqzfFW3jRoFbvdtq5WBiWYVVc 55y9WBGW7t5H+BJA5nVeX/gQ+auCkc5w4tkyZYIXOO/fp8CetC0o7SICapspQp4FxDGaOn5zx CZtYNvOMxfmJSCc6ePwP3v8Zn+kwg41BfVFx9dexwQg6GDgPZEk+Bh29Xpcy2qyLI4gsLEvUB w9hZtMkjdM6CjujUKZQdh1sXQ1ICiGbbx2sdNOVWEYxRCixAHS6tIskqqPfsdUv02LShPMWEo uKptrDSQhFbD3EmkdpQt8J+NZlItPqcW2FA2xemdDTaUJT+UXeZyRLClsJsfEmU7jtZDg7gCz ZEj4chWa03lZxkWwSiFPKZ2u39OawrDCg9xqxjXuBlzjzun+K+wcGZTnvIKWJgPg/PL+z/BZ9 2M3OmncLc7HToNL6iaBr4u3mqCVL4UcKiG28pugU9Y1tZw58s/hrU2QbBhVgRlv7MrLm2xHl7 ZUA9zaH64ctw3v+3tftgVTfp2r90DWsZiVcpNxOBh5O7pxuuuFBPZBxS6hof/t2OX/xvKTI2V BLUShw+yvsWp/4+UyPPPvj1izvQYHca8NfeQ5fpwUX8SKG1L3txDUUXxM4MQM726TzXNjHQmk rdNsEOn6LeI8PSpyrZbHuYV2bidWWLhGZvIR/huBUl8Nd2Wk4xZroH/eUmy4L/CdNh12MJ6Sn WADFurbCDdM+ls+0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 14, 2016 6:29:53 PM CEST Andrey Smirnov wrote: > DT_MACHINE_START(IMX35_DT, "Freescale i.MX35 (Device Tree Support)") > .map_io = mx35_map_io, > .init_early = imx35_init_early, > - .init_irq = imx35_irq_init, > + .init_irq = mx35_init_irq, > .dt_compat = imx35_dt_board_compat, > + .l2c_aux_val = 0, > + .l2c_aux_mask = ~0, > MACHINE_END > Please keep the fields sorted the same way that they are defined in struct machine_desc, i.e. add the new fields at the top of this list. Otherwise the whole series looks good to me now, Acked-by: Arnd Bergmann