Re: [PATCH v2 04/10] drm/nouveau/fb: add GK20A support

Alexandre Courbot
2014-04-23T02:07:57Z

On 04/22/2014 07:40 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Apr 21, 2014 at 03:02:16PM +0900, Alexandre Courbot wrote:
> [...]
>> diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c b/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c
> [...]
>> + pages = dma_alloc_from_contiguous(dev, ncmin, order);
>> + if (!pages) {
>> + gk20a_ram_put(pfb, &mem);
>> + return -ENOMEM;
>> + }
>> +
>> + dma_addr = pfn_to_dma(nv_device_base(nv_device(pfb)),
>> + page_to_pfn(pages));
>
> This breaks compilation on x86 because neither pfn_to_dma() nor
> dma_to_pfn() are available. Is there some other way this can be
> allocated so that these functions don't need to be called?

Mmm, this is bad. There is probably another more portable way to do
this. Let me look for it.

Thanks,
Alex.