From: Behan Webster <behanw@converseincode.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, dwmw2@infradead.org,
pageexec@freemail.hu
Subject: Re: [PATCH] x86: LLVMLinux: Wrap -mno-80387 with cc-option
Date: Mon, 21 Apr 2014 23:23:46 -0700 [thread overview]
Message-ID: <53560AF2.8000106@converseincode.com> (raw)
In-Reply-To: <20140422060544.GA9133@gmail.com>
On 04/21/14 23:05, Ingo Molnar wrote:
> * behanw@converseincode.com <behanw@converseincode.com> wrote:
>
>> From: Behan Webster <behanw@converseincode.com>
>>
>> Wrap -mno-80387 gcc options with cc-option so they don't break clang.
>>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> ---
>> arch/x86/Makefile | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>> index d1b7c37..ce6ad7e 100644
>> --- a/arch/x86/Makefile
>> +++ b/arch/x86/Makefile
>> @@ -83,7 +83,9 @@ else
>> KBUILD_CFLAGS += -m64
>>
>> # Don't autogenerate traditional x87, MMX or SSE instructions
>> - KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387
>> + KBUILD_CFLAGS += -mno-mmx -mno-sse
>> + KBUILD_CFLAGS += $(call cc-option,-mno-80387)
>> + KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)
> Is there a clang equivalent option that inhibits all things FPU opcode
> generation by the compiler?
Not that I've found yet. Still investigating.
> That's the general purpose of -no-80387.
Yes, I understand what this is trying to accomplish. At this point I'd
just like this new code not to break the use of clang with v3.15.
I will submit another patch which adds similar functionality when
compiled with clang once I have that answer.
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2014-04-22 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 5:40 [PATCH] x86: LLVMLinux: Wrap -mno-80387 with cc-option behanw
2014-04-22 6:05 ` Ingo Molnar
2014-04-22 6:23 ` Behan Webster [this message]
2014-04-22 9:42 ` Ingo Molnar
2014-04-22 9:45 ` [tip:x86/urgent] " tip-bot for Behan Webster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53560AF2.8000106@converseincode.com \
--to=behanw@converseincode.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pageexec@freemail.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox