From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
navin patidar <navin.patidar@gmail.com>
Cc: devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.
Date: Tue, 22 Apr 2014 09:28:00 -0500 [thread overview]
Message-ID: <53567C70.2080008@lwfinger.net> (raw)
In-Reply-To: <20140422141417.GM26890@mwanda>
On 04/22/2014 09:14 AM, Dan Carpenter wrote:
> On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
>> Hi dan
>>
>> it's just a cleanup patch and i also tested all patches of this patch
>> series on the hardware (TP-LINK TL-WN723N).
>> my mistake i should have added "Tested-by" tag for all patches.
>>
>> Tested-by: navin patidar <navin.patidar@gmail.com>
>
> No no. It's not necesary to add a tested by to everything. It was just
> something I was curious about. The patches looked ok. If you hadn't
> tested them I would review them a second time more carefully.
To me, the opposite case is true. If you have not tested, then you need to
explicitly state "compile tested only" in the commit message. Without saying
that, your signed-off-by is implying that you have tested, as well as declaring
that you own the copyright to the material.
Larry
next prev parent reply other threads:[~2014-04-22 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 8:47 [PATCH 01/10] staging: rtl8188eu: Remove empty header file navin patidar
2014-04-20 8:47 ` [PATCH 02/10] staging: rtl8188eu: Remove rtw_led_blink_cmd() function navin patidar
2014-04-20 8:47 ` [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function navin patidar
2014-04-22 10:11 ` Dan Carpenter
2014-04-22 14:01 ` navin patidar
2014-04-22 14:14 ` Dan Carpenter
2014-04-22 14:28 ` Larry Finger [this message]
2014-04-22 14:49 ` Dan Carpenter
2014-04-23 3:45 ` navin patidar
2014-04-20 8:47 ` [PATCH 04/10] staging: rtl8188eu: Remove _InitHWLed() function navin patidar
2014-04-20 8:47 ` [PATCH 05/10] staging: rtl8188eu: Simplify led blinking strategy code navin patidar
2014-04-22 10:21 ` Dan Carpenter
2014-04-20 8:47 ` [PATCH 06/10] staging: rtl8188eu: Remove enum LED_STRATEGY_871x navin patidar
2014-04-20 8:47 ` [PATCH 07/10] staging: rtl8188eu: refactor led related structures navin patidar
2014-04-20 8:47 ` [PATCH 08/10] staging: rtl8188eu: Remove unused macros navin patidar
2014-04-20 8:47 ` [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members navin patidar
2014-04-22 10:35 ` Dan Carpenter
2014-04-23 3:31 ` navin patidar
2014-04-23 8:37 ` Dan Carpenter
2014-04-20 8:47 ` [PATCH 10/10] staging: rtl8188eu: Remove unused enum LED_CTL_MODE members navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53567C70.2080008@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin.patidar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox