From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs
Date: Tue, 22 Apr 2014 15:13:46 -0400 [thread overview]
Message-ID: <5356BF6A.2070801@redhat.com> (raw)
In-Reply-To: <jpg7g6h72ln.fsf@nelium.bos.redhat.com>
Il 22/04/2014 12:25, Bandan Das ha scritto:
>>> >> + if (j < i)
>>> >> + shadow_read_write_fields[j] =
>>> >> + shadow_read_write_fields[i];
>>> >> + j++;
>> >
>> > ... you need to respin anyway because the j++ is wrong. It should be
>> > inside the "if". If you prefer, you can put it in the lhs of the
> j++ outside the "if" looks right to me. Can you please explain why
> you think it shouldn't be that way ?
>
The way you wrote it, j will always be equal to i.
Paolo
next prev parent reply other threads:[~2014-04-22 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 19:20 [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs Bandan Das
2014-04-22 3:29 ` Paolo Bonzini
2014-04-22 16:25 ` Bandan Das
2014-04-22 19:13 ` Paolo Bonzini [this message]
2014-04-22 19:31 ` Bandan Das
2014-04-26 9:42 ` Paolo Bonzini
2014-04-28 9:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356BF6A.2070801@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox