From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965630AbcALOGK (ORCPT ); Tue, 12 Jan 2016 09:06:10 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:54176 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934137AbcALOGG (ORCPT ); Tue, 12 Jan 2016 09:06:06 -0500 From: Arnd Bergmann To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, mmarek@suse.com, linux-kbuild@vger.kernel.org, Behan Webster , Jan-Simon =?ISO-8859-1?Q?M=F6ller?= Subject: Re: [PATCH] kbuild: Demote 'sign-compare' warning to W=2 Date: Tue, 12 Jan 2016 15:05:20 +0100 Message-ID: <5357543.n41BTU6AbM@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1452605519-26797-1-git-send-email-lee.jones@linaro.org> References: <1452605519-26797-1-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jAbXJU4wvP1CUuO+RIXePHxykacYJJfSn4GnqWbAdH4zjYjc3jF 4jghUb/HlHT3WiGU7kq/ZyGyZrkj8bIjTpIzjIVfKdWqIWJS+s/JMU2l8JTd0yu6R6tFg5Z kSDwZF96XukmH7a6J8V//BjtMpJLCcvv6HFXqhckCw3LLQbDFYVhirnQ5TFt7jL76ecuaPE zTQtdf8jOIMbQsaSRs1jw== X-UI-Out-Filterresults: notjunk:1;V01:K0:5x7xrBc7Yww=:RUEOAcamoFdrXjC3a2EFir ME9GkcASpcSMo0Z/dJ+C8hzopVDn/X6LhNRjv1ZvLxgGNyYkH+33J9dOGew89a5+chn8jtzAr fN2SpshRaONvJFeDlqmAOfxx/Bs3Q4do6OC5n4AZKPm65dLgu5bRECnzH8shyh+r4JN+oRofG 74JovDHpcqeHSUH5h0aiUuFoOiRHD3laZDRmRMDSw8vMxyy8f5+iHbzcFcmKXLdLku6gX/ygT xxSTacSc500FTLN+CZB7RsiDNzz4Xpak4e6pb69lKlFrfHXNmG+S67ofONA7IsluH58UY1ovv fszVkHBmQZHyuIN9+BWZbff5Jz/2hO5FDZexO0+X3t8n/OjYsedhr6e+0tzrHLFC2cijYoPS4 NZbaLJsDtQ7mtb1KFd0/B14T2gYSyj1DHAONtGg/Ux1IFtae/L2MjaFzGG6cvY3bnwnjwOpv+ VzVTAe+wtbuGmrwUJaH8Fn34W1Me4Gw/h0GCANegL8tYBgMMmTgqlTtrv1OIX6kvjKu4fMS3v upZqu9fKKgyFhBbrF9nH02RTQ18nbJOzbAx9QtHM3ld9ywr+O7GAFPrFjhlNVfJ170yvbELXU vjuzCT6Sc7Vqh/Kl0or5iOdG/e3OrDL0pqPLJYOyYocOlWfqMdin/QQvHUIRgrZvg69c0tVtt TkjTKNyHJyC9BQ3FW7UYmPalTwQZzsi/lHZmrl0xkV3/++Y2bjXXV9c7drGBiu3VF019ORLZv u1DfOoDQFKSHFTe9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 12 January 2016 13:31:59 Lee Jones wrote: > Ideally, a kernel compile with W=1 enabled should complete cleanly; > however, when we run one currently we are presented with ~25k warnings. > 'sign-compare' accounts for ~22k of those ~25k. > > In this patch we're demoting 'sign-compare' warnings to W=2, with a view > to fixing the remaining 3k W=1 warnings required for a clean build. > > Cc: Arnd Bergmann > Signed-off-by: Lee Jones > As per our discussion, I'd add that this was inadvertedly introduced by Behan when he moved the clang specific warnings into an ifdef block and did not notice that -Wsign-compare was interpreted by both gcc and clang. Earlier, it was introduced in just the same way by Jan-Simon as part of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation with clang"). The new patch looks good to me, please add Acked-by: Arnd Bergmann Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3") I've started looking into building the kernel with clang, and will likely follow up with further unrelated changes to the list, as clang-3.9 seems to generate a couple of extra warnings we want to suppress. Arnd