From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581AbaDWJqN (ORCPT ); Wed, 23 Apr 2014 05:46:13 -0400 Received: from top.free-electrons.com ([176.31.233.9]:55849 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752401AbaDWJqK (ORCPT ); Wed, 23 Apr 2014 05:46:10 -0400 Message-ID: <53578BC9.3070908@free-electrons.com> Date: Wed, 23 Apr 2014 11:45:45 +0200 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Alexandre Belloni , Nicolas Ferre CC: Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: at91/dt: sam9rl: Fix PLL output range and mck divisors References: <1398243220-20874-1-git-send-email-alexandre.belloni@free-electrons.com> <1398243220-20874-3-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1398243220-20874-3-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/2014 10:53, Alexandre Belloni wrote: > Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing. > Also, the at91sam9rl doesn't really have a by 3 divisor. > > Signed-off-by: Alexandre Belloni Acked-by: Boris BREZILLON > --- > arch/arm/boot/dts/at91sam9rl.dtsi | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts/at91sam9rl.dtsi > index a19a7c26a7fc..1109e7fbf9bd 100644 > --- a/arch/arm/boot/dts/at91sam9rl.dtsi > +++ b/arch/arm/boot/dts/at91sam9rl.dtsi > @@ -574,8 +574,9 @@ > clocks = <&main>; > reg = <0>; > atmel,clk-input-range = <1000000 32000000>; > - #atmel,pll-clk-output-range-cells = <4>; > - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>; > + #atmel,pll-clk-output-range-cells = <3>; > + atmel,pll-clk-output-ranges = <80000000 200000000 0>, > + <190000000 240000000 2>; > }; > > utmi: utmick { > @@ -592,7 +593,7 @@ > interrupts-extended = <&pmc AT91_PMC_MCKRDY>; > clocks = <&clk32k>, <&main>, <&plla>, <&utmi>; > atmel,clk-output-range = <0 94000000>; > - atmel,clk-divisors = <1 2 4 3>; > + atmel,clk-divisors = <1 2 4 0>; > }; > > prog: progck { -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com