Re: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

Re: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

[Ian Abbott]

On 2014-04-17 07:33, Chase Southwood wrote:
> The reset function for this driver is a bit of a mess; clean it up to
> ensure that it is functioning properly.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> ---
> 2: *Changed order of register accesses for digital input registers back to
> original ordering.
> *Removed read of digital output status register and reordered the accesses
> of digital output registers to agree with the order found in addi_apci_2032.
> *Fixed copy/paste error in the counter register reset lines.
>
> 3: *Returned the reset callback to the boardinfo...oops.
> *Don't write APCI1564_DO_IRQ_REG (it's read only).
> *Don't clear counter reload values...counters have already been
> disabled.
>
> 4: Leave this in hwdrv_apci1564.c for now (it can be moved after separating
> this driver from addi_common.c)
>
> NB: This patch has been renamed in this version.  It was previously known
> as "staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()"
>
>   .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 24 ++++++++++++++--------
>   1 file changed, 15 insertions(+), 9 deletions(-)

Looks okay and it addresses the concerns raised by Hartley.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

RE: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

[Hartley Sweeten]

On Wednesday, April 23, 2014 12:09 AM, Chase Southwood wrote:
>>On Thursday, April 17, 2014 1:33 AM, Chase Southwood <chase.southwood@yahoo.com> wrote:
>
>> The reset function for this driver is a bit of a mess; clean it up to
>> ensure that it is functioning properly.
>>
>> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
>> ---
>> 2: *Changed order of register accesses for digital input registers back to
>> original ordering.
>> *Removed read of digital output status register and reordered the accesses
>> of digital output registers to agree with the order found in addi_apci_2032.
>> *Fixed copy/paste error in the counter register reset lines.
>>
>> 3: *Returned the reset callback to the boardinfo...oops.
>> *Don't write APCI1564_DO_IRQ_REG (it's read only).
>> *Don't clear counter reload values...counters have already been
>> disabled.
>>
>> 4: Leave this in hwdrv_apci1564.c for now (it can be moved after separating
>> this driver from addi_common.c)
>>
>>NB: This patch has been renamed in this version.  It was previously known
>>as "staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()"
>>
>
>
> Ian and Hartley,
>
> Just following up to see if you have any comments on this version of this patch.
> PATCH 1/2 from this set was added to staging-next today, and I'd like to know
> where this one stands before I work on separating this driver from addi_common.c.
> I'd be happy to make any more changes that are desired, or if it's just better to
> drop the patch for now, that's ok too.  Just want to make sure it's taken care of
> before I move on!

Sorry, I thought I already responded to this...

Looks good now.

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>