From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Jan Moskyto Matejka <mq@suse.cz>, Randy Dunlap <rdunlap@infradead.org>
Cc: mtk.manpages@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"
Date: Wed, 23 Apr 2014 14:48:52 +0200 [thread overview]
Message-ID: <5357B6B4.6020008@gmail.com> (raw)
In-Reply-To: <20140423094836.GA10953@moskyto.dyndns.org>
On 04/23/2014 11:48 AM, Jan Moskyto Matejka wrote:
> n Tue, Apr 22, 2014 at 03:35:39PM -0700, Randy Dunlap wrote:
>> On 04/22/14 11:19, Michael Kerrisk (man-pages) wrote:
>>> On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote:
>>>> The sum at the beginning of line "intr" includes also unnumbered interrupts.
>>>> It implies that the sum at the beginning isn't the sum of the remainder of the
>>>> line, not even an estimation.
>>>>
>>>> Fixed the documentation to mention that.
>>>
>>> I'm not really doubting what you claim, Jan, but it would be really
>>> helpful if you provided some data to support the proposed change
>>> (Kernel source references, or notes about testing you've done, or
>>> pointers to mailing list threads, authoritative note that you are
>>> the maintainer of some relevant kernel subsystem...). Do you have
>>> something like that? (It's also useful for the change log.)
>>
>> I wouldn't mind more of a changelog, but the additional text is
>> certainly correct.
>>
>> Thanks. I'll apply the patch, but more changelog comments are welcome.
>
> Thank you for applying.
>
> You may add following line to the changelog:
> This behaviour was added to /proc/stat in commit a2eddfa95919a730e0e5ed17e9c303fe5ba249cd.
Thanks, Jan -- that's indeed helpful for the man-pages changelog!
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2014-04-23 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 15:29 [PATCH] proc: fix documentation for /proc/stat, line "intr" Jan Moskyto Matejka
2014-04-22 18:19 ` Michael Kerrisk (man-pages)
2014-04-22 22:35 ` Randy Dunlap
2014-04-23 4:57 ` Michael Kerrisk (man-pages)
2014-04-23 5:14 ` Michael Kerrisk (man-pages)
2014-04-23 9:48 ` Jan Moskyto Matejka
2014-04-23 12:48 ` Michael Kerrisk (man-pages) [this message]
2014-04-27 0:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357B6B4.6020008@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mq@suse.cz \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox