From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, sarah.a.sharp@linux.intel.com,
linux-kernel@vger.kernel.org,
Alexander Gordeev <agordeev@redhat.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/5] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Fri, 25 Apr 2014 13:48:13 +0300 [thread overview]
Message-ID: <535A3D6D.8020008@linux.intel.com> (raw)
In-Reply-To: <20140424194926.GB12809@kroah.com>
On 04/24/2014 10:49 PM, Greg KH wrote:
> On Tue, Apr 22, 2014 at 03:22:59PM +0300, Mathias Nyman wrote:
>> From: Alexander Gordeev <agordeev@redhat.com>
>>
>> As result of deprecation of MSI-X/MSI enablement functions
>> pci_enable_msix() and pci_enable_msi_block() all drivers
>> using these two interfaces need to be updated to use the
>> new pci_enable_msi_range() or pci_enable_msi_exact()
>> and pci_enable_msix_range() or pci_enable_msix_exact()
>> interfaces.
>>
>> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
>> Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-usb@vger.kernel.org
>> Cc: linux-pci@vger.kernel.org
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>> ---
>> drivers/usb/host/xhci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index 988ed5f..b0b8399 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -291,7 +291,7 @@ static int xhci_setup_msix(struct xhci_hcd *xhci)
>> xhci->msix_entries[i].vector = 0;
>> }
>>
>> - ret = pci_enable_msix(pdev, xhci->msix_entries, xhci->msix_count);
>> + ret = pci_enable_msix_exact(pdev, xhci->msix_entries, xhci->msix_count);
>
> Why is this change needed for 3.15-final?
>
Can't remember why I thought this was needed for 3.15
Looks like other subsystems (like PCI) just queued similar MSI changes
for 3.16.
I'll move it to the patchseries for usb-next
-Mathias
next prev parent reply other threads:[~2014-04-25 10:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 12:22 [PATCH 0/5] xhci: fixes for 3.15-rc usb-linus Mathias Nyman
2014-04-22 12:22 ` [PATCH 1/5] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb Mathias Nyman
2014-04-24 19:49 ` Greg KH
2014-04-24 20:15 ` Julius Werner
2014-04-22 12:22 ` [PATCH 2/5] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix() Mathias Nyman
2014-04-24 19:49 ` Greg KH
2014-04-25 10:48 ` Mathias Nyman [this message]
2014-04-22 12:23 ` [PATCH 3/5] xhci: Switch Intel Lynx Point ports to EHCI on shutdown Mathias Nyman
2014-04-24 19:49 ` Greg KH
2014-04-22 12:23 ` [PATCH 4/5] xhci: extend quirk for Renesas cards Mathias Nyman
2014-04-24 19:50 ` Greg KH
2014-04-22 12:23 ` [PATCH 5/5] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM Mathias Nyman
2014-04-24 19:50 ` Greg KH
2014-04-24 20:15 ` David Cohen
2014-04-24 19:50 ` [PATCH 0/5] xhci: fixes for 3.15-rc usb-linus Greg KH
2014-04-25 8:11 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A3D6D.8020008@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=agordeev@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox