From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754646AbaDYUwj (ORCPT ); Fri, 25 Apr 2014 16:52:39 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42447 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876AbaDYUwd (ORCPT ); Fri, 25 Apr 2014 16:52:33 -0400 Message-ID: <535ACB0E.4070600@infradead.org> Date: Fri, 25 Apr 2014 13:52:30 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Rik van Riel CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Richard Weinberger , linux-next@vger.kernel.org, "Paul E. McKenney" , umgwanakikbuti@gmail.com Subject: Re: mmotm 2014-04-24-13-07 uploaded References: <20140424200837.727695A407C@corp2gmr1-2.hot.corp.google.com> <535992DD.3060808@infradead.org> <20140425100459.7824f676@annuminas.surriel.com> <535AC91A.1070504@infradead.org> In-Reply-To: <535AC91A.1070504@infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/25/14 13:44, Randy Dunlap wrote: > On 04/25/14 07:04, Rik van Riel wrote: >> On Thu, 24 Apr 2014 15:40:29 -0700 >> Randy Dunlap wrote: >> >> >>> uml on x86_64 defconfig: >>> >>> drivers/built-in.o: In function `__handle_sysrq': >>> drivers/tty/sysrq.c:514: undefined reference to `rcu_sysrq_start' >>> drivers/tty/sysrq.c:558: undefined reference to `rcu_sysrq_end' >> >> Randy, does the patch below fix it? CONFIG_TINY_RCU=y tiny.c does not provide these functions... Paul... > Hm, no, it does not. I'll look into it. > >> Mike, this patch should also address your concerns. >> >> Andrew, this can be a -fix patch for the sysctl-rcu patch, >> assuming it fixes things :) >> >> Signed-off-by: Rik van Riel > --- >> drivers/tty/sysrq.c | 1 + >> kernel/rcu/update.c | 3 ++- >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c >> index dd53af9..0867433 100644 >> --- a/drivers/tty/sysrq.c >> +++ b/drivers/tty/sysrq.c >> @@ -46,6 +46,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c >> index 2ac3289..d22309c 100644 >> --- a/kernel/rcu/update.c >> +++ b/kernel/rcu/update.c >> @@ -322,7 +322,8 @@ int rcu_jiffies_till_stall_check(void) >> >> void rcu_sysrq_start(void) >> { >> - rcu_cpu_stall_suppress = 2; >> + if (!rcu_cpu_stall_suppress) >> + rcu_cpu_stall_suppress = 2; >> } >> >> void rcu_sysrq_end(void) >> > > -- ~Randy