From: Yijing Wang <wangyijing@huawei.com>
To: David Laight <David.Laight@ACULAB.COM>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Tony Luck <tony.luck@intel.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 00/13] Refactor pci_is_brdige() to simplify code
Date: Sat, 26 Apr 2014 10:49:24 +0800 [thread overview]
Message-ID: <535B1EB4.3050408@huawei.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6FEEB0@AcuExch.aculab.com>
On 2014/4/25 17:42, David Laight wrote:
> From: Yijing Wang
>> This patchset rename the current pci_is_bridge() to pci_has_subordinate(),
>> and introduce a new pci_is_bridge() which determine pci bridge by check
>> dev->hdr_type. The new one is more accurate. PCIe Spec define the pci
>> device is a bridge by the dev->hdr_type = 0x01 || 0x02.
>
> That is a dangerous rename and is likely to cause difficult to
Hi David,
I renamed pci_is_bridge() to pci_has_subordinate() because
static inline bool pci_is_bridge(struct pci_dev *pci_dev)
{
return !!(pci_dev->subordinate);
}
which always check dev->subordinate.
> identify bugs in any code you've missed.
What are you referring to ?
Thanks!
Yijing.
>
> David
>
> \x04�{.n�+�������+%��lzwm��b�맲��r��zX��\x19\x1e�w��{ay�\x1dʇڙ�,j\a��f���h���z�\x1e�w���\f���j:+v���w�j�m����\a����zZ+�����ݢj"��!�iO��z��v�^\x14\x04\x1a�^[m����\vnƊ��Y&�
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2014-04-26 2:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 9:18 [PATCH 00/13] Refactor pci_is_brdige() to simplify code Yijing Wang
2014-04-25 9:18 ` [PATCH 01/13] PCI: rename pci_is_bridge() to pci_has_subordinate() Yijing Wang
2014-04-25 9:18 ` [PATCH 02/13] PCI: Introduce new pci_is_bridge() helper function Yijing Wang
2014-04-25 9:18 ` [PATCH 03/13] PCI: Use new pci_is_bridge() to simplify code Yijing Wang
2014-04-25 9:18 ` [PATCH 04/13] x86/PCI: " Yijing Wang
2014-04-25 9:18 ` [PATCH 05/13] IA64/PCI: " Yijing Wang
2014-04-25 9:18 ` [PATCH 06/13] powerpc/PCI: " Yijing Wang
2014-04-25 9:18 ` [PATCH 07/13] sparc/PCI: " Yijing Wang
2014-04-25 16:49 ` David Miller
2014-04-25 9:18 ` [PATCH 08/13] PCI, rpaphp: " Yijing Wang
2014-04-28 0:43 ` Benjamin Herrenschmidt
2014-04-25 9:18 ` [PATCH 09/13] PCI, shpchp: " Yijing Wang
2014-04-25 9:18 ` [PATCH 10/13] PCI, cpcihp: " Yijing Wang
2014-04-25 9:18 ` [PATCH 11/13] PCI, acpiphp: " Yijing Wang
2014-04-25 9:18 ` [PATCH 12/13] PCI, pcmcia: " Yijing Wang
2014-04-25 9:18 ` [PATCH 13/13] PCI, pciehp: " Yijing Wang
2014-04-25 9:42 ` [PATCH 00/13] Refactor pci_is_brdige() " David Laight
2014-04-26 2:49 ` Yijing Wang [this message]
2014-04-30 16:29 ` Bjorn Helgaas
2014-05-04 4:16 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535B1EB4.3050408@huawei.com \
--to=wangyijing@huawei.com \
--cc=David.Laight@ACULAB.COM \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox