From: Oren Twaig <oren@scalemp.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Shai Fultheim <shai@scalemp.com>
Subject: Re: [PATCH v2] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore
Date: Sun, 27 Apr 2014 09:57:59 +0300 [thread overview]
Message-ID: <535CAA77.4000405@scalemp.com> (raw)
In-Reply-To: <20140425142248.GL8874@tassilo.jf.intel.com>
Hi Andi,
On 04/25/2014 05:22 PM, Andi Kleen wrote:
>> +static int irc = 1;
> Using a static for such state is very unusual. You need to describe what
> protects it against races and why that is needed over a cleaner solution.
The only reason I've used a static variable is because I wanted to avoid
inserting another code/functions which are depended on CONFIG_PCI. The code is
used once during initialization and hence cannot be racy.
But, if static variables are unusual (new at linux kernel), I will change the
flow to read the HW state again (using the PCI functions). Please let me know if that is desirable.
Thanks,
Oren.
>
> -Andi
next prev parent reply other threads:[~2014-04-27 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 21:52 [PATCH v2] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore Oren Twaig
2014-04-25 8:01 ` Ingo Molnar
2014-04-25 11:08 ` Oren Twaig
2014-04-26 6:09 ` Ingo Molnar
2014-04-27 6:55 ` Oren Twaig
2014-04-27 11:50 ` Ingo Molnar
2014-04-25 14:22 ` Andi Kleen
2014-04-27 6:57 ` Oren Twaig [this message]
2014-04-27 11:54 ` Ingo Molnar
2014-04-27 18:34 ` Andi Kleen
2014-04-28 7:06 ` Oren Twaig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535CAA77.4000405@scalemp.com \
--to=oren@scalemp.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shai@scalemp.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).