From: xiakaixu <xiakaixu@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <paulus@samba.org>,
Ingo Molnar <mingo@kernel.org>, <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Huxinwei <huxinwei@huawei.com>, Genghui <hui.geng@huawei.com>,
<jolsa@redhat.com>, <bp@alien8.de>, Jiri Olsa <jolsa@redhat.com>,
Borislav Petkov <bp@alien8.de>, <peifeiyue@huawei.com>
Subject: Re: [PATCH] perf tools: Remove extra '/' character in events file path
Date: Mon, 28 Apr 2014 10:01:30 +0800 [thread overview]
Message-ID: <535DB67A.2020108@huawei.com> (raw)
In-Reply-To: <87tx9epawt.fsf@sejong.aot.lge.com>
于 2014/4/28 8:14, Namhyung Kim 写道:
> Hi xiakaixu,
>
> (Adding Jiri and Boris to CC)
OK.
thanks,
>
>> The array debugfs_known_mountpoints[] will cause extra '/'
>> character output.
>> Remove it.
>>
>> pre:
>> $ perf probe -l
>> /sys/kernel/debug//tracing/uprobe_events file does not exist -
>> please rebuild kernel with CONFIG_UPROBE_EVENTS.
>>
>> post:
>> $ perf probe -l
>> /sys/kernel/debug/tracing/uprobe_events file does not exist -
>> please rebuild kernel with CONFIG_UPROBE_EVENTS.
>
> Looks like all of its callers already provide a '/' after the debugfs
> mountpoint, so
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>
>>
>> Signed-off-by: Xia Kaixu <xiakaixu@huawei.com>
>> ---
>> tools/lib/api/fs/debugfs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
>> index 7c43479..a74fba6 100644
>> --- a/tools/lib/api/fs/debugfs.c
>> +++ b/tools/lib/api/fs/debugfs.c
>> @@ -12,8 +12,8 @@
>> char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
>>
>> static const char * const debugfs_known_mountpoints[] = {
>> - "/sys/kernel/debug/",
>> - "/debug/",
>> + "/sys/kernel/debug",
>> + "/debug",
>> 0,
>> };
>>
>> -- 1.8.5.5
> .
>
next prev parent reply other threads:[~2014-04-28 2:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 7:55 [PATCH] perf tools: Remove extra '/' character in events file path xiakaixu
2014-04-28 0:14 ` Namhyung Kim
2014-04-28 2:01 ` xiakaixu [this message]
2014-04-28 7:53 ` Borislav Petkov
2014-05-01 6:32 ` [tip:perf/core] " tip-bot for Xia Kaixu
[not found] <5354E37E.9060700@huawei.com>
2014-04-22 3:24 ` [PATCH] " xiakaixu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535DB67A.2020108@huawei.com \
--to=xiakaixu@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=bp@alien8.de \
--cc=hui.geng@huawei.com \
--cc=huxinwei@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peifeiyue@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox