From: Steven Whitehouse <swhiteho@redhat.com>
To: Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers
Date: Mon, 28 Apr 2014 09:48:02 +0100 [thread overview]
Message-ID: <535E15C2.8080203@redhat.com> (raw)
In-Reply-To: <20140426205723.35360f20c80bd33d96c4863d@skynet.be>
Hi,
On 26/04/14 19:57, Fabian Frederick wrote:
> Sparse warning: fs/gfs2/lops.c:78:29:
> "warning: Using plain integer as NULL pointer"
>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/gfs2/lops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Now in the GFS2 -nmw tree. Thanks,
Steve.
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index a294d8d..2c1ae86 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -75,7 +75,7 @@ static void maybe_release_space(struct gfs2_bufdata *bd)
> unsigned int index = bd->bd_bh->b_blocknr - gl->gl_name.ln_number;
> struct gfs2_bitmap *bi = rgd->rd_bits + index;
>
> - if (bi->bi_clone == 0)
> + if (bi->bi_clone == NULL)
> return;
> if (sdp->sd_args.ar_discard)
> gfs2_rgrp_send_discards(sdp, rgd->rd_data0, bd->bd_bh, bi, 1, NULL);
prev parent reply other threads:[~2014-04-28 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 18:57 [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers Fabian Frederick
2014-04-28 8:48 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E15C2.8080203@redhat.com \
--to=swhiteho@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).