public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: micky <micky_ching@realsil.com.cn>
To: <chris@printf.net>, <sameo@linux.intel.com>
Cc: <gregkh@linuxfoundation.org>, <dan.carpenter@oracle.com>,
	<ulf.hansson@linaro.org>, <devel@linuxdriverproject.org>,
	<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
	<rogerable@realtek.com>, <wei_wang@realsil.com.cn>
Subject: Re: [PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle
Date: Mon, 28 Apr 2014 19:30:52 +0800	[thread overview]
Message-ID: <535E3BEC.9040100@realsil.com.cn> (raw)
In-Reply-To: <afbc1328fb8a89fda3da23f1e9c755311450e1f6.1395824147.git.micky_ching@realsil.com.cn>

Hi Chris and Ulf,

This patch should be applied to 3.15(rc), 3.14, 3.13.
without this patch the MMC card can not identified.

Best Regards.
micky.
On 03/27/2014 01:35 PM, micky_ching@realsil.com.cn wrote:
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a
> <mmc: add ignorance case for CMD13 CRC error>
> produced a cmd.flags unhandled in realtek pci host driver.
> This will make MMC card failed initialize, this patch is
> used to handle the new cmd.flags condition and MMC card can be used.
>
> Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
> ---
>   drivers/mmc/host/rtsx_pci_sdmmc.c |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index 5fb994f..0d8904a 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -346,6 +346,9 @@ static void sd_send_cmd(struct realtek_pci_sdmmc *host, struct mmc_command *cmd)
>   	case MMC_RSP_R1:
>   		rsp_type = SD_RSP_TYPE_R1;
>   		break;
> +	case MMC_RSP_R1 & ~MMC_RSP_CRC:
> +		rsp_type = SD_RSP_TYPE_R1 | SD_NO_CHECK_CRC7;
> +		break;
>   	case MMC_RSP_R1B:
>   		rsp_type = SD_RSP_TYPE_R1b;
>   		break;


  reply	other threads:[~2014-04-28 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  5:35 [PATCH v2 0/2] mmc: rtsx: add new cmd type handle and modify error handle micky_ching
2014-03-27  5:35 ` [PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle micky_ching
2014-04-28 11:30   ` micky [this message]
2014-04-28 12:16     ` Dan Carpenter
2014-03-27  5:35 ` [PATCH v2 2/2] mmc: rtsx: modify error handle and remove smatch warnings micky_ching
2014-04-28 11:37   ` [PATCH v2 2/2] mmc: rtsx: modify error handle and remove smatchwarnings micky
2014-04-28 12:40     ` Dan Carpenter
2014-03-27  8:11 ` [PATCH v2 0/2] mmc: rtsx: add new cmd type handle and modify error handle Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535E3BEC.9040100@realsil.com.cn \
    --to=micky_ching@realsil.com.cn \
    --cc=chris@printf.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rogerable@realtek.com \
    --cc=sameo@linux.intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox