From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Robert Baldyga <r.baldyga@samsung.com>,
sameo@linux.intel.com, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
m.szyprowski@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCH v2 1/2] mfd: max77693: remove unnecessary wrapper functions
Date: Tue, 29 Apr 2014 17:05:44 +0900 [thread overview]
Message-ID: <535F5D58.8000007@samsung.com> (raw)
In-Reply-To: <20140429075202.GA29462@lee--X1>
On 04/29/2014 04:52 PM, Lee Jones wrote:
>> This patch removes wrapper functions used to access regmap, and
>> make driver using regmap_*() functions instead.
>>
>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>> ---
>> drivers/extcon/extcon-max77693.c | 32 ++++++++++-----------
>> drivers/mfd/max77693-irq.c | 50 +++++++++++++++++++-------------
>> drivers/mfd/max77693.c | 56 ++----------------------------------
>> drivers/regulator/max77693.c | 12 ++++----
>> include/linux/mfd/max77693-private.h | 8 ------
>> 5 files changed, 54 insertions(+), 104 deletions(-)
>
> Bye bye abstraction for the sake for abstraction. Works for me!
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Chanwoo,
> I can add this to ib-mfd-extcon-3.16 with your Ack if you like.
> That should make things somewhat easier.
>
OK,
For extcon part about patch[1-2].
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2014-04-29 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 5:48 [PATCH v2 0/2] mfd: max77693: improve regmap support Robert Baldyga
2014-04-29 5:48 ` [PATCH v2 1/2] mfd: max77693: remove unnecessary wrapper functions Robert Baldyga
2014-04-29 6:41 ` Krzysztof Kozlowski
2014-04-29 7:52 ` Lee Jones
2014-04-29 8:05 ` Chanwoo Choi [this message]
2014-04-29 5:48 ` [PATCH v2 2/2] mfd: max77693: handle IRQs using regmap Robert Baldyga
2014-04-29 6:42 ` Krzysztof Kozlowski
2014-04-29 7:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535F5D58.8000007@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.zummo@towertech.it \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox