From: "H. Peter Anvin" <hpa@zytor.com>
To: behanw@converseincode.com, viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, dwmw2@infradead.org,
Mark Charlebois <charlebm@gmail.com>
Subject: Re: [PATCH] mbcache: LLVMLinux: Remove double calculation from mbcache
Date: Tue, 29 Apr 2014 22:19:17 -0700 [thread overview]
Message-ID: <536087D5.1040409@zytor.com> (raw)
In-Reply-To: <a54957c1-4825-4265-8126-4565168fe8c6@email.android.com>
On 04/29/2014 06:13 PM, H. Peter Anvin wrote:
> I suspect this will generate FP instructions on x86 which will corrupt user space state. This is thus a critical bug!!
It looks like at least x86-64 gcc does the evaluation at compile time
and there aren't any fp instructions left in the code. However, it
should still be fixed.
-hpa
next prev parent reply other threads:[~2014-04-30 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 1:10 [PATCH] mbcache: LLVMLinux: Remove double calculation from mbcache behanw
2014-04-30 1:13 ` H. Peter Anvin
2014-04-30 5:19 ` H. Peter Anvin [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-22 5:19 behanw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536087D5.1040409@zytor.com \
--to=hpa@zytor.com \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox