From: Paolo Bonzini <pbonzini@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Jet Chen <jet.chen@intel.com>,
"Romer, Benjamin M" <Benjamin.Romer@unisys.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Borislav Petkov <bp@alien8.de>,
LKML <linux-kernel@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP
Date: Wed, 30 Apr 2014 12:02:34 +0200 [thread overview]
Message-ID: <5360CA3A.2040706@redhat.com> (raw)
In-Reply-To: <5348291B.7090501@zytor.com>
Il 11/04/2014 19:40, H. Peter Anvin ha scritto:
> On 04/11/2014 10:35 AM, Jet Chen wrote:
>>
>> As Peter said, QEMU probably should *not* set the hypervisor bit. But based on my testing, I think KVM works properly in this case.
>>
>
> Either way, unless there is a CPUID interface exposed in CPUID levels
> 0x40000000+, then relying on the hypervisor bit to do VMCALL is wrong in
> the extreme.
Sorry for the delay guys, I was on vacation.
Lack of a CPUID interface at 0x40000000 is indeed *the* good reason why
QEMU should not set the hypervisor bit. Of course that there is no
guarantee that QEMU will never expose a 0x40000000 interface, and at
that point the hypervisor bit may reappear in QEMU's JIT mode.
As to sending #UD to the guest at CPL>0, that is a choice of the
hypervisor. Hyper-V (and KVM in Hyper-V emulation mode) does that, and
does the same in real mode too. KVM instead sets EAX to -KVM_EPERM, and
accepts hypercalls in real mode (where CPL=0). Terminating the guest is
surely the wrong thing to do at CPL>0.
Thanks,
Paolo
next prev parent reply other threads:[~2014-04-30 10:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 11:17 [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP Fengguang Wu
2014-04-07 14:04 ` Ken Cox
2014-04-07 14:09 ` Greg Kroah-Hartman
2014-04-07 14:24 ` Ken Cox
2014-04-07 19:23 ` Greg Kroah-Hartman
2014-04-07 19:46 ` Greg Kroah-Hartman
[not found] ` <C97001BC43954D438ACB059713BA5CDF92040F0F00@USEA-EXCH7.na.uis.unisys.com>
2014-04-08 2:53 ` Fengguang Wu
2014-04-08 15:39 ` Romer, Benjamin M
[not found] ` <53444220.50009@intel.com>
[not found] ` <C97001BC43954D438ACB059713BA5CDF92040F0F06@USEA-EXCH7.na.uis.unisys.com>
[not found] ` <53458A3A.1050608@intel.com>
2014-04-09 23:01 ` Fengguang Wu
2014-04-09 23:10 ` H. Peter Anvin
2014-04-10 13:19 ` Romer, Benjamin M
2014-04-11 2:28 ` H. Peter Anvin
2014-04-11 13:51 ` Romer, Benjamin M
2014-04-11 16:33 ` H. Peter Anvin
2014-04-11 17:35 ` Jet Chen
2014-04-11 17:40 ` H. Peter Anvin
2014-04-11 17:51 ` Romer, Benjamin M
2014-04-30 10:02 ` Paolo Bonzini [this message]
2014-04-11 17:49 ` Romer, Benjamin M
2014-04-13 11:51 ` Borislav Petkov
2014-04-13 12:20 ` Jet Chen
2014-04-09 23:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5360CA3A.2040706@redhat.com \
--to=pbonzini@redhat.com \
--cc=Benjamin.Romer@unisys.com \
--cc=bp@alien8.de \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=jet.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).