Re: [PATCH 5/5 v3] iio: exynos_adc: do a reinit_completion before the conversion

Jonathan Cameron
2014-05-01T05:48:28Z

On May 1, 2014 12:23:27 AM GMT+01:00, Doug Anderson <dianders@chromium.org> wrote:
>Jonathan,
>
>On Wed, Apr 30, 2014 at 1:49 PM, Jonathan Cameron <jic23@kernel.org>
>wrote:
>> On 30/04/14 10:26, Naveen Krishna Chatradhi wrote:
>>>
>>> Add reinit_completion() before the wait_for_completion_timeout in
>>> raw_read() call.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>>
>> Applied to the togreg branch of iio.git
>> I wasn't sure if this one was technically a fix, but as it isn't
>> marked clearly as such it can go in during the next merge window.
>> I won't have pushed this out to a non rebasing branch until tomorrow
>> so if this fixes an observed issue then let me know and it might move
>> to the fixes-togreg branch.
>
>As far as I know this doesn't fix an observed issue. I believe it was
>requested as part of a previous review and is finally reposted. I
>believe it's just extra precautions to make sure that some old IRQ
>didn't accidentally complete us between the last transaction and this
>one.
>
>Old discussion is somewhere around here
><https://patchwork.kernel.org/patch/2279591/>
Thanks for clarifying this.

J
>
>Thanks!
>
>-Doug

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.