* [PATCH] fbdev/fb.h: silence warning with -Wsign-compare
@ 2014-05-01 19:32 Brian W Hart
2014-05-02 12:59 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Brian W Hart @ 2014-05-01 19:32 UTC (permalink / raw)
To: plagnioj, tomi.valkeinen, linux-fbdev, linux-kernel, trivial
Silence the warning when building with -Wsign-compare when fb.h is
included:
include/linux/fb.h: In function ‘__fb_pad_aligned_buffer’:
include/linux/fb.h:650:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (j = 0; j < s_pitch; j++)
^
Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
---
Compile tested only.
include/linux/fb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fb.h b/include/linux/fb.h
index fe6ac95..0da7634 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -641,7 +641,7 @@ static inline void unlock_fb_info(struct fb_info *info)
static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
u8 *src, u32 s_pitch, u32 height)
{
- int i, j;
+ u32 i, j;
d_pitch -= s_pitch;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev/fb.h: silence warning with -Wsign-compare
2014-05-01 19:32 [PATCH] fbdev/fb.h: silence warning with -Wsign-compare Brian W Hart
@ 2014-05-02 12:59 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-05-02 12:59 UTC (permalink / raw)
To: Brian W Hart, plagnioj, linux-fbdev, linux-kernel, trivial
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
On 01/05/14 22:32, Brian W Hart wrote:
> Silence the warning when building with -Wsign-compare when fb.h is
> included:
>
> include/linux/fb.h: In function ‘__fb_pad_aligned_buffer’:
> include/linux/fb.h:650:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
> for (j = 0; j < s_pitch; j++)
> ^
>
> Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
> ---
> Compile tested only.
>
> include/linux/fb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index fe6ac95..0da7634 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -641,7 +641,7 @@ static inline void unlock_fb_info(struct fb_info *info)
> static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
> u8 *src, u32 s_pitch, u32 height)
> {
> - int i, j;
> + u32 i, j;
>
> d_pitch -= s_pitch;
>
>
Thanks, queued for 3.16.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-02 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-01 19:32 [PATCH] fbdev/fb.h: silence warning with -Wsign-compare Brian W Hart
2014-05-02 12:59 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox