From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbaEBSO0 (ORCPT ); Fri, 2 May 2014 14:14:26 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:37956 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbaEBSOY (ORCPT ); Fri, 2 May 2014 14:14:24 -0400 Message-ID: <5363E07B.7040805@gmail.com> Date: Fri, 02 May 2014 12:14:19 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Jiri Olsa , Christian Borntraeger CC: Paolo Bonzini , KVM , linux-s390 , Cornelia Huck , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Ingo Molnar , Alexander Yarygin Subject: Re: [PATCH/RFC 00/11] perf/s390/kvm: trace events, perf kvm stat References: <1398417153-57347-1-git-send-email-borntraeger@de.ibm.com> <20140502091638.GA6327@krava.redhat.com> In-Reply-To: <20140502091638.GA6327@krava.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/2/14, 3:16 AM, Jiri Olsa wrote: > On Fri, Apr 25, 2014 at 11:12:22AM +0200, Christian Borntraeger wrote: >> The goal of this series is to >> - enable perf kvm stat on s390 >> - get rid of a perf warning "insn_to_mnemonic not found" when it tries to >> decode s390 perf trace events > > perf tools changes look good to me > >> >> Review feedback is welcome. > > CC-ing David Ahern > I don't have the original emails, but looking at https://lkml.org/lkml/2014/4/25/331 [PATCH 01/11] s390: add sie exit reasons tables [PATCH 02/11] KVM: s390: Use trace tables from sie.h [PATCH 03/11] KVM: s390: decoder of SIE intercepted instructions [PATCH 04/11] KVM: s390: Use intercept_insn decoder in trace event - not perf related [PATCH 05/11] perf kvm: Intoduce HAVE_KVM_STAT_SUPPORT flag [PATCH 06/11] perf kvm: simplify of exit reasons tables definitions [PATCH 07/11] perf kvm: Refactoring of cpu_isa_config() [PATCH 10/11] perf: allow to use cpuinfo on s390 Reviewed-by: David Ahern [PATCH 09/11] perf kvm: use defines of kvm events - KVM team should ack kvm.h change - perf side looks fine to me [PATCH 11/11] perf kvm: add stat support on s390 - like to see the arch bits moved to arch/x86 and arch/s390 rather than adding #ifdefs - disabling ioport and mmio options is ok, but if you are going to compile it out update the documentation accordingly. David