* [PATCH 0/2] drivers/rtc/rtc-puv3.c: fix 2 typo issues.
@ 2014-05-03 5:06 Chen Gang
2014-05-03 5:07 ` [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue Chen Gang
2014-05-03 5:09 ` [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0 Chen Gang
0 siblings, 2 replies; 5+ messages in thread
From: Chen Gang @ 2014-05-03 5:06 UTC (permalink / raw)
To: Guan Xuetao, a.zummo, sangjung.woo
Cc: rtc-linux, linux-kernel@vger.kernel.org
Fix 2 typo issues for commit "1fbc4c4 drivers/rtc/rtc-puv3.c: use
dev_dbg() instead of pr_debug()".
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/rtc/rtc-puv3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue
2014-05-03 5:06 [PATCH 0/2] drivers/rtc/rtc-puv3.c: fix 2 typo issues Chen Gang
@ 2014-05-03 5:07 ` Chen Gang
2014-05-12 7:53 ` 回复： " 管雪涛
2014-05-03 5:09 ` [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0 Chen Gang
1 sibling, 1 reply; 5+ messages in thread
From: Chen Gang @ 2014-05-03 5:07 UTC (permalink / raw)
To: Guan Xuetao, a.zummo, sangjung.woo
Cc: rtc-linux, linux-kernel@vger.kernel.org
It is only a typo issue, the related commit:
"1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
The related error (unicore32 with allmodconfig):
CC [M] drivers/rtc/rtc-puv3.o
drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setpie’:
drivers/rtc/rtc-puv3.c:74: error: implicit declaration of function ‘dev_debug’
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/rtc/rtc-puv3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
index 1ecfe3b..c56310e 100644
--- a/drivers/rtc/rtc-puv3.c
+++ b/drivers/rtc/rtc-puv3.c
@@ -71,7 +71,7 @@ static int puv3_rtc_setpie(struct device *dev, int enabled)
{
unsigned int tmp;
- dev_debug(dev, "%s: pie=%d\n", __func__, enabled);
+ dev_dbg(dev, "%s: pie=%d\n", __func__, enabled);
spin_lock_irq(&puv3_rtc_pie_lock);
tmp = readl(RTC_RTSR) & ~RTC_RTSR_HZE;
--
1.9.2.459.g68773ac
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0
2014-05-03 5:06 [PATCH 0/2] drivers/rtc/rtc-puv3.c: fix 2 typo issues Chen Gang
2014-05-03 5:07 ` [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue Chen Gang
@ 2014-05-03 5:09 ` Chen Gang
2014-05-12 7:56 ` 回复： " 管雪涛
1 sibling, 1 reply; 5+ messages in thread
From: Chen Gang @ 2014-05-03 5:09 UTC (permalink / raw)
To: Guan Xuetao, a.zummo, sangjung.woo
Cc: rtc-linux, linux-kernel@vger.kernel.org
It is only a typo issue, the related commit:
"1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
The related error (for unicore32 with allmodconfig):
CC [M] drivers/rtc/rtc-puv3.o
drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setalarm’:
drivers/rtc/rtc-puv3.c:143: error: ‘struct device’ has no member named ‘dev’
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/rtc/rtc-puv3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
index c56310e..1cff2a2 100644
--- a/drivers/rtc/rtc-puv3.c
+++ b/drivers/rtc/rtc-puv3.c
@@ -140,7 +140,7 @@ static int puv3_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
rtc_tm_to_time(tm, &rtcalarm_count);
writel(rtcalarm_count, RTC_RTAR);
- puv3_rtc_setaie(&dev->dev, alrm->enabled);
+ puv3_rtc_setaie(dev, alrm->enabled);
if (alrm->enabled)
enable_irq_wake(puv3_rtc_alarmno);
--
1.9.2.459.g68773ac
^ permalink raw reply related [flat|nested] 5+ messages in thread
* 回复： [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue
2014-05-03 5:07 ` [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue Chen Gang
@ 2014-05-12 7:53 ` 管雪涛
0 siblings, 0 replies; 5+ messages in thread
From: 管雪涛 @ 2014-05-12 7:53 UTC (permalink / raw)
To: Chen Gang; +Cc: Guan Xuetao, a zummo, sangjung woo, rtc-linux, linux-kernel
Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> It is only a typo issue, the related commit:
>
> "1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
>
> The related error (unicore32 with allmodconfig):
>
> CC [M] drivers/rtc/rtc-puv3.o
> drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setpie’:
> drivers/rtc/rtc-puv3.c:74: error: implicit declaration of function ‘dev_debug’
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/rtc/rtc-puv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index 1ecfe3b..c56310e 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -71,7 +71,7 @@ static int puv3_rtc_setpie(struct device *dev, int enabled)
> {
> unsigned int tmp;
>
> - dev_debug(dev, "%s: pie=%d\n", __func__, enabled);
> + dev_dbg(dev, "%s: pie=%d\n", __func__, enabled);
>
> spin_lock_irq(&puv3_rtc_pie_lock);
> tmp = readl(RTC_RTSR) & ~RTC_RTSR_HZE;
> --
> 1.9.2.459.g68773ac
^ permalink raw reply [flat|nested] 5+ messages in thread
* 回复： [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0
2014-05-03 5:09 ` [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0 Chen Gang
@ 2014-05-12 7:56 ` 管雪涛
0 siblings, 0 replies; 5+ messages in thread
From: 管雪涛 @ 2014-05-12 7:56 UTC (permalink / raw)
To: Chen Gang; +Cc: Guan Xuetao, a zummo, sangjung woo, rtc-linux, linux-kernel
Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> It is only a typo issue, the related commit:
>
> "1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
>
> The related error (for unicore32 with allmodconfig):
>
> CC [M] drivers/rtc/rtc-puv3.o
> drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setalarm’:
> drivers/rtc/rtc-puv3.c:143: error: ‘struct device’ has no member named ‘dev’
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/rtc/rtc-puv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index c56310e..1cff2a2 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -140,7 +140,7 @@ static int puv3_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
> rtc_tm_to_time(tm, &rtcalarm_count);
> writel(rtcalarm_count, RTC_RTAR);
>
> - puv3_rtc_setaie(&dev->dev, alrm->enabled);
> + puv3_rtc_setaie(dev, alrm->enabled);
>
> if (alrm->enabled)
> enable_irq_wake(puv3_rtc_alarmno);
> --
> 1.9.2.459.g68773ac
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-12 7:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-03 5:06 [PATCH 0/2] drivers/rtc/rtc-puv3.c: fix 2 typo issues Chen Gang
2014-05-03 5:07 ` [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue Chen Gang
2014-05-12 7:53 ` 回复： " 管雪涛
2014-05-03 5:09 ` [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0 Chen Gang
2014-05-12 7:56 ` 回复： " 管雪涛
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).