Re: [PATCH 2/2] ARM: dts: hip04: add gpio pieces

[Zhou Wang <wangzhou1@hisilicon.com>]

On 2014/4/23 19:51, Zhou Wang wrote:
> Hisilicon Soc hip04 has four gpio controllers, each one has 32
> gpios and can be configured to be an interrupt controller.
> The gpio controllers are compatible with the snps,dw-apb-gpio
> driver. This patch add the corresponding device tree nodes.
> 
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> ---
>  arch/arm/boot/dts/hip04.dtsi |   76 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
> index 7e909ee..c7c1f8c 100644
> --- a/arch/arm/boot/dts/hip04.dtsi
> +++ b/arch/arm/boot/dts/hip04.dtsi
> @@ -235,5 +235,81 @@
>  			reg-shift = <2>;
>  			status = "disabled";
>  		};
> +
> +		gpio@4003000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "snps,dw-apb-gpio";
> +			reg = <0x4003000 0x1000>;
> +
> +			gpio3: gpio-controller@0 {
> +				compatible = "snps,dw-apb-gpio-port";
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				snps,nr-gpios = <32>;
> +				reg = <0>;
> +				interrupt-parent = <&gic>;
> +				interrupt-controller;
> +				#interrupt-cells = <2>;
> +				interrupts = <0 392 4>;
> +			};
> +		};
> +
> +		gpio@4002000 {
> + 			#address-cells = <1>;
> + 			#size-cells = <0>;
> + 			compatible = "snps,dw-apb-gpio";
> + 			reg = <0x4002000 0x1000>;
> +
> + 			gpio2: gpio-controller@0 {
> + 				compatible = "snps,dw-apb-gpio-port";
> + 				gpio-controller;
> + 				#gpio-cells = <2>;
> + 				snps,nr-gpios = <32>;
> + 				reg = <0>;
> +				interrupt-parent = <&gic>;
> + 				interrupt-controller;
> + 				#interrupt-cells = <2>;
> + 				interrupts = <0 391 4>;
> + 			};
> + 		};
> +
> +		gpio@4001000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "snps,dw-apb-gpio";
> +			reg = <0x4001000 0x1000>;
> +
> +			gpio1: gpio-controller@0 {
> +				compatible = "snps,dw-apb-gpio-port";
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				snps,nr-gpios = <32>;
> +				reg = <0>;
> +				interrupt-parent = <&gic>;
> +				interrupt-controller;
> +				#interrupt-cells = <2>;
> +				interrupts = <0 390 4>;
> +			};
> +		};
> +
> +		gpio@4000000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "snps,dw-apb-gpio";
> +			reg = <0x4000000 0x1000>;
> +
> +			gpio0: gpio-controller@0 {
> +				compatible = "snps,dw-apb-gpio-port";
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				snps,nr-gpios = <32>;
> +				reg = <0>;
> +				interrupt-parent = <&gic>;
> +				interrupt-controller;
> +				#interrupt-cells = <2>;
> +				interrupts = <0 389 4>;
> +			};
> +		};
>  	};
>  };
> -- 1.7.9.5
> 
Hi haojian

 Are the gpio nodes OK for hip04.dtsi?

Best regards
Zhou Wang