From: Martin Walch <walch.martin@web.de>
To: linux-kbuild@vger.kernel.org
Cc: "Michal Marek" <mmarek@suse.cz>,
"Arve Hjønnevåg" <arve@android.com>,
"Jiri Kosina" <trivial@kernel.org>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
"Benjamin Poirier" <bpoirier@suse.de>,
"Dirk Gouders" <dirk@gouders.net>,
"Wang YanQing" <udknight@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Kees Cook" <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/5] kconfig: adjust warning message for conflicting types
Date: Thu, 03 Oct 2013 19:24:46 +0200 [thread overview]
Message-ID: <5367004.amEGKp5Frc@tacticalops> (raw)
From: Martin Walch <walch.martin@web.de>
Date: Thu, 3 Oct 2013 18:32:02 +0200
Subject: [PATCH v2 3/5] kconfig: adjust warning message for conflicting types
Each symbol must have exactly one type assigned. However, if a symbol happens
to have two different types assigned at runtime, a warning is printed and the
first type is preserved while the second type is being ignored.
The warning message says
type of <symbol name> redefined from <first type> to <second type>
which may be misleading as it may create the impression that the second type
replaces the first type.
This patch clarifies this by changing the warning to
ignoring type redefinition of <symbol name> from <first type> to <second type>
Signed-off-by: Martin Walch <walch.martin@web.de>
---
| 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index b970101..9e69f19 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -119,9 +119,10 @@ void menu_set_type(int type)
sym->type = type;
return;
}
- menu_warn(current_entry, "type of '%s' redefined from '%s' to '%s'",
- sym->name ? sym->name : "<choice>",
- sym_type_name(sym->type), sym_type_name(type));
+ menu_warn(current_entry,
+ "ignoring type redefinition of '%s' from '%s' to '%s'",
+ sym->name ? sym->name : "<choice>",
+ sym_type_name(sym->type), sym_type_name(type));
}
struct property *menu_add_prop(enum prop_type type, char *prompt, struct expr *expr, struct expr *dep)
--
1.8.1.5
next reply other threads:[~2013-10-03 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 17:24 Martin Walch [this message]
2013-10-04 14:25 ` [PATCH v2 3/5] kconfig: adjust warning message for conflicting types Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5367004.amEGKp5Frc@tacticalops \
--to=walch.martin@web.de \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=bpoirier@suse.de \
--cc=dirk@gouders.net \
--cc=jdelvare@suse.de \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=trivial@kernel.org \
--cc=udknight@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox