From: Roger Quadros <rogerq@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: <rydberg@euromail.se>, <balbi@ti.com>, <dmurphy@ti.com>,
<mugunthanvnm@ti.com>, <nsekhar@ti.com>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations
Date: Mon, 5 May 2014 11:44:10 +0300 [thread overview]
Message-ID: <53674F5A.3080006@ti.com> (raw)
In-Reply-To: <20140430163041.GB13624@core.coreip.homeip.net>
On 04/30/2014 07:30 PM, Dmitry Torokhov wrote:
> Hi Roger,
>
> On Wed, Apr 30, 2014 at 03:36:26PM +0300, Roger Quadros wrote:
>
>> static int pixcir_i2c_ts_remove(struct i2c_client *client)
>> @@ -198,10 +194,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client *client)
>>
>> tsdata->exiting = true;
>> mb();
>> - free_irq(client->irq, tsdata);
>>
>> input_unregister_device(tsdata->input);
>
> There is no need to call input_unregister_device for managed input
> devices.
OK. I'll remove that.
>
>> - kfree(tsdata);
>>
>> return 0;
>> }
cheers,
-roger
next prev parent reply other threads:[~2014-05-05 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 12:36 [PATCH v3 0/7] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support Roger Quadros
2014-04-30 12:36 ` [PATCH v3 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations Roger Quadros
2014-04-30 16:30 ` Dmitry Torokhov
2014-05-05 8:44 ` Roger Quadros [this message]
2014-04-30 12:36 ` [PATCH v3 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode Roger Quadros
2014-04-30 16:29 ` Dmitry Torokhov
2014-05-05 8:42 ` Roger Quadros
2014-04-30 12:36 ` [PATCH v3 3/7] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val() Roger Quadros
2014-04-30 12:36 ` [PATCH v3 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol Roger Quadros
2014-04-30 12:36 ` [PATCH v3 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs Roger Quadros
2014-04-30 12:36 ` [PATCH v3 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend Roger Quadros
2014-04-30 12:36 ` [PATCH v3 7/7] Input: pixcir_i2c_ts: Add device tree support Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53674F5A.3080006@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox