From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932465AbaEEMop (ORCPT ); Mon, 5 May 2014 08:44:45 -0400 Received: from mx02.posteo.de ([89.146.194.165]:42250 "EHLO posteo.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932189AbaEEMon (ORCPT ); Mon, 5 May 2014 08:44:43 -0400 Message-ID: <536787B7.80200@posteo.de> Date: Mon, 05 May 2014 14:44:39 +0200 From: Martin Kepplinger User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: Dan Carpenter CC: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, lidza.louina@gmail.com Subject: Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk() References: <1398765250-16064-1-git-send-email-martink@posteo.de> <1399285779-7040-1-git-send-email-martink@posteo.de> <20140505113507.GP26890@mwanda> <53677D1D.5000204@posteo.de> <20140505123603.GQ26890@mwanda> In-Reply-To: <20140505123603.GQ26890@mwanda> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2014-05-05 14:36, schrieb Dan Carpenter: > On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote: >> Am 2014-05-05 13:35, schrieb Dan Carpenter: >>> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: >>>> Use dev_err() instead of printk() and remove "dgnc:" from the message. >>>> This should provide userspace with more useful information and use >>>> the common kernel coding style. >>>> >>> >>> Whenever I see a "RESEND" in a subject and no explanation then it means >>> our development process has broken down. Meanwhile this is the first >>> time I have seen this patch so the problem is not on our side. >>> >>> regards, >>> dan carpenter >>> >> >> I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week >> or so. I don't see any breakdown. > > What I'm saying is just put an explanation after the --- cut off so we > know what you did wrong the first time. > > Signed-off-by ... > --- > Resending because I sent it to the wrong email list the first time. > Oops! Next time I will use get_maintainer.pl, I promise! > > > Just a simple explanation like that is ok. > > regards, > dan carpenter > sure, thanks.