* [PATCH] staging: dgnc: use dev_err() instead of printk()
@ 2014-04-29 9:43 Martin Kepplinger
2014-04-29 9:54 ` Martin Kepplinger
0 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2014-04-29 9:43 UTC (permalink / raw)
To: gregkh; +Cc: lidza.louina, linux-kernel, Martin Kepplinger
Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/staging/dgnc/dgnc_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..0f0e8fc 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device *c)
ret = sysfs_create_group(&c->kobj, &dgnc_tty_attribute_group);
if (ret) {
- printk(KERN_ERR "dgnc: failed to create sysfs tty device attributes.\n");
+ dev_err(c, "dgnc: failed to create sysfs tty device attributes.\n");
sysfs_remove_group(&c->kobj, &dgnc_tty_attribute_group);
return;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] staging: dgnc: use dev_err() instead of printk()
2014-04-29 9:43 [PATCH] staging: dgnc: use dev_err() instead of printk() Martin Kepplinger
@ 2014-04-29 9:54 ` Martin Kepplinger
2014-05-05 10:29 ` [RESEND PATCH] " Martin Kepplinger
0 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2014-04-29 9:54 UTC (permalink / raw)
To: gregkh; +Cc: lidza.louina, linux-kernel, Martin Kepplinger
Use dev_err() insted of printk() and remove "dgnc:" from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
This makes probably more sense than the previous one.
drivers/staging/dgnc/dgnc_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..88a2106 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device *c)
ret = sysfs_create_group(&c->kobj, &dgnc_tty_attribute_group);
if (ret) {
- printk(KERN_ERR "dgnc: failed to create sysfs tty device attributes.\n");
+ dev_err(c, "failed to create sysfs tty device attributes.\n");
sysfs_remove_group(&c->kobj, &dgnc_tty_attribute_group);
return;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
2014-04-29 9:54 ` Martin Kepplinger
@ 2014-05-05 10:29 ` Martin Kepplinger
2014-05-05 11:35 ` Dan Carpenter
0 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2014-05-05 10:29 UTC (permalink / raw)
To: gregkh; +Cc: lidza.louina, driverdev-devel, linux-kernel, Martin Kepplinger
Use dev_err() instead of printk() and remove "dgnc:" from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/staging/dgnc/dgnc_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
index 946230c..88a2106 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -739,7 +739,7 @@ void dgnc_create_tty_sysfs(struct un_t *un, struct device *c)
ret = sysfs_create_group(&c->kobj, &dgnc_tty_attribute_group);
if (ret) {
- printk(KERN_ERR "dgnc: failed to create sysfs tty device attributes.\n");
+ dev_err(c, "failed to create sysfs tty device attributes.\n");
sysfs_remove_group(&c->kobj, &dgnc_tty_attribute_group);
return;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
2014-05-05 10:29 ` [RESEND PATCH] " Martin Kepplinger
@ 2014-05-05 11:35 ` Dan Carpenter
2014-05-05 11:59 ` Martin Kepplinger
0 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2014-05-05 11:35 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: gregkh, lidza.louina, driverdev-devel, linux-kernel
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
> Use dev_err() instead of printk() and remove "dgnc:" from the message.
> This should provide userspace with more useful information and use
> the common kernel coding style.
>
Whenever I see a "RESEND" in a subject and no explanation then it means
our development process has broken down. Meanwhile this is the first
time I have seen this patch so the problem is not on our side.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
2014-05-05 11:35 ` Dan Carpenter
@ 2014-05-05 11:59 ` Martin Kepplinger
2014-05-05 12:36 ` Dan Carpenter
0 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2014-05-05 11:59 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, lidza.louina, driverdev-devel, linux-kernel
Am 2014-05-05 13:35, schrieb Dan Carpenter:
> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
>> Use dev_err() instead of printk() and remove "dgnc:" from the message.
>> This should provide userspace with more useful information and use
>> the common kernel coding style.
>>
>
> Whenever I see a "RESEND" in a subject and no explanation then it means
> our development process has broken down. Meanwhile this is the first
> time I have seen this patch so the problem is not on our side.
>
> regards,
> dan carpenter
>
I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week
or so. I don't see any breakdown.
martin
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
2014-05-05 11:59 ` Martin Kepplinger
@ 2014-05-05 12:36 ` Dan Carpenter
2014-05-05 12:44 ` Martin Kepplinger
0 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2014-05-05 12:36 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: gregkh, driverdev-devel, linux-kernel, lidza.louina
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
> Am 2014-05-05 13:35, schrieb Dan Carpenter:
> > On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
> >> Use dev_err() instead of printk() and remove "dgnc:" from the message.
> >> This should provide userspace with more useful information and use
> >> the common kernel coding style.
> >>
> >
> > Whenever I see a "RESEND" in a subject and no explanation then it means
> > our development process has broken down. Meanwhile this is the first
> > time I have seen this patch so the problem is not on our side.
> >
> > regards,
> > dan carpenter
> >
>
> I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week
> or so. I don't see any breakdown.
What I'm saying is just put an explanation after the --- cut off so we
know what you did wrong the first time.
Signed-off-by ...
---
Resending because I sent it to the wrong email list the first time.
Oops! Next time I will use get_maintainer.pl, I promise!
Just a simple explanation like that is ok.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
2014-05-05 12:36 ` Dan Carpenter
@ 2014-05-05 12:44 ` Martin Kepplinger
0 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2014-05-05 12:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, driverdev-devel, linux-kernel, lidza.louina
Am 2014-05-05 14:36, schrieb Dan Carpenter:
> On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
>> Am 2014-05-05 13:35, schrieb Dan Carpenter:
>>> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
>>>> Use dev_err() instead of printk() and remove "dgnc:" from the message.
>>>> This should provide userspace with more useful information and use
>>>> the common kernel coding style.
>>>>
>>>
>>> Whenever I see a "RESEND" in a subject and no explanation then it means
>>> our development process has broken down. Meanwhile this is the first
>>> time I have seen this patch so the problem is not on our side.
>>>
>>> regards,
>>> dan carpenter
>>>
>>
>> I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week
>> or so. I don't see any breakdown.
>
> What I'm saying is just put an explanation after the --- cut off so we
> know what you did wrong the first time.
>
> Signed-off-by ...
> ---
> Resending because I sent it to the wrong email list the first time.
> Oops! Next time I will use get_maintainer.pl, I promise!
>
>
> Just a simple explanation like that is ok.
>
> regards,
> dan carpenter
>
sure, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-05 12:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 9:43 [PATCH] staging: dgnc: use dev_err() instead of printk() Martin Kepplinger
2014-04-29 9:54 ` Martin Kepplinger
2014-05-05 10:29 ` [RESEND PATCH] " Martin Kepplinger
2014-05-05 11:35 ` Dan Carpenter
2014-05-05 11:59 ` Martin Kepplinger
2014-05-05 12:36 ` Dan Carpenter
2014-05-05 12:44 ` Martin Kepplinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox