From: Denys Vlasenko <dvlasenk@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jim Keniston <jkenisto@us.ibm.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] uprobes: fix scratch register selection for rip-relative fixups
Date: Mon, 05 May 2014 19:32:32 +0200 [thread overview]
Message-ID: <5367CB30.2070604@redhat.com> (raw)
In-Reply-To: <20140505154559.GA27072@redhat.com>
On 05/05/2014 05:45 PM, Oleg Nesterov wrote:
> On 05/02, Denys Vlasenko wrote:
>> static inline unsigned long *
>> scratch_reg(struct arch_uprobe *auprobe, struct pt_regs *regs)
>> {
>> - return (auprobe->def.fixups & UPROBE_FIX_RIP_AX) ? ®s->ax : ®s->cx;
>> + /* Order is important - more than one bit can be set! */
>
> Really?
>
> Should I remove this comment or I misread the change in riprel_analyze?
Yes, it is not true: latest code sets only one bit.
prev parent reply other threads:[~2014-05-05 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 15:04 [PATCH v2] uprobes: fix scratch register selection for rip-relative fixups Denys Vlasenko
2014-05-02 23:43 ` Jim Keniston
2014-05-05 15:45 ` Oleg Nesterov
2014-05-05 15:47 ` Oleg Nesterov
2014-05-05 17:32 ` Denys Vlasenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5367CB30.2070604@redhat.com \
--to=dvlasenk@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox