From: RAGHAVENDRA GANIGA <ravi23ganiga@gmail.com>
To: a.zummo@towertech.it, rtc-linux@googlegroups.com
Cc: linux-kernel@vger.kernel.org
Subject: rtc: add support for maxim dallas rtc ds1343 and ds1344
Date: Mon, 05 May 2014 23:46:06 +0530 [thread overview]
Message-ID: <5367D566.7000601@gmail.com> (raw)
> On Wed, 30 Apr 2014 21:55:07 +0530
> Raghavendra Ganiga <ravi23ganiga@gmail.com> wrote:
>> +static int ds1343_proc(struct device *dev, struct seq_file *seq)
>> +{
>> + struct ds1343_priv *priv = dev_get_drvdata(dev);
>> + unsigned int data;
>> + unsigned char alarm_mode = 0;
>> + const char *alarm_str, *diodes = "disabled", *resistors = " ";
>> +
>> + regmap_read(priv->map, DS1343_CONTROL_REG, &data);
> is this thing really useful? what about having sysfs entries
> instead?
i am replacing the proc interface with the sysfs entries
also removing the unnecessary parameters. i am adding the
following parameters as sysfs entries
1. glitch filter read and write parameter
2. alarm status read parameter
3. alarm mode read parameter
4. trickle charger read parameter
and i am removing the proc interface.
is the above implementation ok as per your last comment
on the proc interface. please provide the feedback.
Thanks and regards
Raghavendra Chandra Ganiga
next reply other threads:[~2014-05-05 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 18:16 RAGHAVENDRA GANIGA [this message]
2014-05-06 9:57 ` rtc: add support for maxim dallas rtc ds1343 and ds1344 Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5367D566.7000601@gmail.com \
--to=ravi23ganiga@gmail.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox