* rtc: add support for maxim dallas rtc ds1343 and ds1344
@ 2014-05-05 18:16 RAGHAVENDRA GANIGA
2014-05-06 9:57 ` Alessandro Zummo
0 siblings, 1 reply; 2+ messages in thread
From: RAGHAVENDRA GANIGA @ 2014-05-05 18:16 UTC (permalink / raw)
To: a.zummo, rtc-linux; +Cc: linux-kernel
> On Wed, 30 Apr 2014 21:55:07 +0530
> Raghavendra Ganiga <ravi23ganiga@gmail.com> wrote:
>> +static int ds1343_proc(struct device *dev, struct seq_file *seq)
>> +{
>> + struct ds1343_priv *priv = dev_get_drvdata(dev);
>> + unsigned int data;
>> + unsigned char alarm_mode = 0;
>> + const char *alarm_str, *diodes = "disabled", *resistors = " ";
>> +
>> + regmap_read(priv->map, DS1343_CONTROL_REG, &data);
> is this thing really useful? what about having sysfs entries
> instead?
i am replacing the proc interface with the sysfs entries
also removing the unnecessary parameters. i am adding the
following parameters as sysfs entries
1. glitch filter read and write parameter
2. alarm status read parameter
3. alarm mode read parameter
4. trickle charger read parameter
and i am removing the proc interface.
is the above implementation ok as per your last comment
on the proc interface. please provide the feedback.
Thanks and regards
Raghavendra Chandra Ganiga
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: rtc: add support for maxim dallas rtc ds1343 and ds1344
2014-05-05 18:16 rtc: add support for maxim dallas rtc ds1343 and ds1344 RAGHAVENDRA GANIGA
@ 2014-05-06 9:57 ` Alessandro Zummo
0 siblings, 0 replies; 2+ messages in thread
From: Alessandro Zummo @ 2014-05-06 9:57 UTC (permalink / raw)
To: RAGHAVENDRA GANIGA; +Cc: rtc-linux, linux-kernel
On Mon, 05 May 2014 23:46:06 +0530
RAGHAVENDRA GANIGA <ravi23ganiga@gmail.com> wrote:
> 1. glitch filter read and write parameter
> 2. alarm status read parameter
> 3. alarm mode read parameter
> 4. trickle charger read parameter
>
> and i am removing the proc interface.
>
> is the above implementation ok as per your last comment
> on the proc interface. please provide the feedback.
That's sounds like a plan. Please send the code when you're ready.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-06 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-05 18:16 rtc: add support for maxim dallas rtc ds1343 and ds1344 RAGHAVENDRA GANIGA
2014-05-06 9:57 ` Alessandro Zummo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox