[PATCH 1/2] kernel/cpuset.c: kernel-doc fixes

[PATCH 1/2] kernel/cpuset.c: kernel-doc fixes

[Fabian Frederick]

This patch also converts seq_printf to seq_puts

Cc: Li Zefan <lizefan@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 kernel/cpuset.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 3d54c41..1d8c047 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -890,6 +890,7 @@ static void update_tasks_cpumask_hier(struct cpuset *root_cs, bool update_root)
 /**
  * update_cpumask - update the cpus_allowed mask of a cpuset and all tasks in it
  * @cs: the cpuset to consider
+ * @trialcs: trial cpuset
  * @buf: buffer of cpu numbers written to this cpuset
  */
 static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs,
@@ -2536,7 +2537,7 @@ int cpuset_mems_allowed_intersects(const struct task_struct *tsk1,
 
 /**
  * cpuset_print_task_mems_allowed - prints task's cpuset and mems_allowed
- * @task: pointer to task_struct of some task.
+ * @tsk: pointer to task_struct of some task.
  *
  * Description: Prints @task's name, cpuset name, and cached copy of its
  * mems_allowed to the kernel log.
@@ -2646,10 +2647,10 @@ out:
 /* Display task mems_allowed in /proc/<pid>/status file. */
 void cpuset_task_status_allowed(struct seq_file *m, struct task_struct *task)
 {
-	seq_printf(m, "Mems_allowed:\t");
+	seq_puts(m, "Mems_allowed:\t");
 	seq_nodemask(m, &task->mems_allowed);
-	seq_printf(m, "\n");
-	seq_printf(m, "Mems_allowed_list:\t");
+	seq_puts(m, "\n");
+	seq_puts(m, "Mems_allowed_list:\t");
 	seq_nodemask_list(m, &task->mems_allowed);
-	seq_printf(m, "\n");
+	seq_puts(m, "\n");
 }
-- 
1.9.1

Re: [PATCH 1/2] kernel/cpuset.c: kernel-doc fixes

[Li Zefan]

On 2014/5/6 1:46, Fabian Frederick wrote:
> This patch also converts seq_printf to seq_puts
> 
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Acked-by: Li Zefan <lizefan@huawei.com>

> ---
>  kernel/cpuset.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
...
>  void cpuset_task_status_allowed(struct seq_file *m, struct task_struct *task)
>  {
> -	seq_printf(m, "Mems_allowed:\t");
> +	seq_puts(m, "Mems_allowed:\t");
>  	seq_nodemask(m, &task->mems_allowed);
> -	seq_printf(m, "\n");
> -	seq_printf(m, "Mems_allowed_list:\t");
> +	seq_puts(m, "\n");

will seq_putc() produce slightly smaller code?

> +	seq_puts(m, "Mems_allowed_list:\t");
>  	seq_nodemask_list(m, &task->mems_allowed);
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");
>  }
> 

Re: [PATCH 1/2] kernel/cpuset.c: kernel-doc fixes

[Tejun Heo]

On Mon, May 05, 2014 at 07:46:55PM +0200, Fabian Frederick wrote:
> This patch also converts seq_printf to seq_puts
> 
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Applied to cgroup/for-3.16.

Thanks.

-- 
tejun