public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Ingo Molnar <mingo@kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH/RFC] Deprecate BUG/BUG_ON in favour of BUG_AND_HALT/BUG_AND_HALT_ON
Date: Tue, 06 May 2014 11:41:13 +0200	[thread overview]
Message-ID: <5368AE39.1030402@nod.at> (raw)
In-Reply-To: <20140506093548.GA27476@gmail.com>



Am 06.05.2014 11:35, schrieb Ingo Molnar:
> 
> * Richard Weinberger <richard@nod.at> wrote:
> 
>>>> I like the idea but not the name.
>>>> What about DIE() and DIE_ON()?
>>>
>>> CRASH_ON() might be a suggestive name as well, as from the user's 
>>> point of view we are crashing her system.
>>
>> I fear such users will think "Why should I crash the kernel?". ;-)
> 
> That's exactly the impression that the naming should create in kernel 
> developers why try to add CRASH_ON() in the future: only do it as an 
> absolute last resort.
> 
> WARN_ON() and other non-destructive ways to deal with error conditions 
> are almost always preferred.

Yeah, I was actually referring to the joke where one asks to remove all BUG() and BUG_ON() to
make the kernel bug free.

Thanks,
//richard

  reply	other threads:[~2014-05-06  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 15:03 [PATCH/RFC] Deprecate BUG/BUG_ON in favour of BUG_AND_HALT/BUG_AND_HALT_ON Paul Gortmaker
2014-05-03 18:33 ` Richard Weinberger
2014-05-06  7:35   ` Ingo Molnar
2014-05-06  8:08     ` Richard Weinberger
2014-05-06  9:35       ` Ingo Molnar
2014-05-06  9:41         ` Richard Weinberger [this message]
2014-05-06 14:35     ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368AE39.1030402@nod.at \
    --to=richard@nod.at \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox