From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757914AbaEFPQm (ORCPT ); Tue, 6 May 2014 11:16:42 -0400 Received: from mga02.intel.com ([134.134.136.20]:4918 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755059AbaEFPQl (ORCPT ); Tue, 6 May 2014 11:16:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,997,1389772800"; d="scan'208";a="535580777" Message-ID: <5368FDB6.3000107@linux.intel.com> Date: Tue, 06 May 2014 08:20:22 -0700 From: Srinivas Pandruvada User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Jean Delvare CC: Guenter Roeck , "Yu, Fenghua" , Linux Kernel , lm-sensors@lm-sensors.org Subject: Re: [lm-sensors] coretemp.0 folder contents changed References: <5367C6A7.5020008@linux.intel.com> <20140505173231.GA25644@roeck-us.net> <20140506135558.3cafd062@endymion.delvare> In-Reply-To: <20140506135558.3cafd062@endymion.delvare> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2014 04:55 AM, Jean Delvare wrote: > Hi Guenter, Srinivas, > > On Mon, 5 May 2014 10:32:31 -0700, Guenter Roeck wrote: >> On Mon, May 05, 2014 at 10:13:11AM -0700, Srinivas Pandruvada wrote: >>> for kernel : 3.15.rc3 . >>> >>> Is there any change in the coretemp? Previously we used to see, >>> tempx data (like temp2_input, temp2_max etc.) >>> /sys/devices/platform/coretemp.0/. >> That isn't where you are supposed to look for hwmon attributes. > Actually I used to recommend looking there when people were not using > libsensors (e.g. for pwmconfig / fancontrol or custom scripts.) This > path had the great merit of being stable across reboots, while hwmon > class device numbers are not (or at least they aren't guaranteed to be.) I maintain thermal daemon, which was using the path. So once Ubuntu upgrade kernel, this will break. So I have to make sure that corresponding user space change is submitted. I don't want to depend on too many libraries as it also runs on many embedded platforms where many library pre-builts don't exists. >> (...) >> To give you the background, hwmon attributes are in the process of >> being moved from the parent device to the hwmon device, or from >> /sys/class/hwmon/hwmonX/device/ to /sys/class/hwmon/hwmonX/, >> as part of an effort to streamline the code and make it more >> consistent and maintainable. > I am just realizing that we are also losing the stability of hardware > device based paths with that move :( I suppose I shouldn't have > bothered adding support for this to fancontrol. > > Don't get me wrong, I still believe this is the right move, but I fear > that the question of persistent hwmon device names will resurface every > now and then again. libsensors offers a solution but 1* it lacks > support for pwm attributes and 2* it doesn't help with shell or perl > scripts such as pwmconfig and fancontrol. Also when using Android like platform with limited library support, we have to make sure that libsensor exists. Thanks, Srinivas