From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbaEFSxa (ORCPT ); Tue, 6 May 2014 14:53:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbaEFSx3 (ORCPT ); Tue, 6 May 2014 14:53:29 -0400 Message-ID: <53692F9F.1050000@redhat.com> Date: Tue, 06 May 2014 14:53:19 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Mel Gorman , Linux-MM , Linux-FSDevel CC: Johannes Weiner , Vlastimil Babka , Jan Kara , Michal Hocko , Hugh Dickins , Linux Kernel Subject: Re: [PATCH 13/17] mm: shmem: Avoid atomic operation during shmem_getpage_gfp References: <1398933888-4940-1-git-send-email-mgorman@suse.de> <1398933888-4940-14-git-send-email-mgorman@suse.de> In-Reply-To: <1398933888-4940-14-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/2014 04:44 AM, Mel Gorman wrote: > shmem_getpage_gfp uses an atomic operation to set the SwapBacked field > before it's even added to the LRU or visible. This is unnecessary as what > could it possible race against? Use an unlocked variant. > > Signed-off-by: Mel Gorman > Acked-by: Johannes Weiner Acked-by: Rik van Riel -- All rights reversed