From: Stephen Warren <swarren@wwwdotorg.org>
To: Christopher Freeman <cfreeman@nvidia.com>,
ldewangan@nvidia.com, swarren@nvidia.com, vinod.koul@intel.com,
dan.j.williams@intel.com
Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] dma: tegra: avoid int overflow for transferred count
Date: Wed, 07 May 2014 10:38:59 -0600 [thread overview]
Message-ID: <536A61A3.3050601@wwwdotorg.org> (raw)
In-Reply-To: <1399411343-12222-4-git-send-email-cfreeman@nvidia.com>
On 05/06/2014 03:22 PM, Christopher Freeman wrote:
> bytes_transferred will overflow during long audio playbacks. Since
> the driver only ever consults this value modulo bytes_requested, store the
> value modulo bytes_requested.
The audio driver may only interpret the value modulo bytes_requested,
but what about other drivers such as the high-speed UART (and SPI?) drivers?
What is the dmaengine API's design requirement here, and what do other
dmaengine drivers do. If it's to store the modulo, then I'm fine with
this change.
next prev parent reply other threads:[~2014-05-07 16:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 21:22 [PATCH v1 0/3] Tegra DMA residue improvements Christopher Freeman
2014-05-06 21:22 ` [PATCH v1 1/3] dma: tegra: finer granularity residual for tx_status Christopher Freeman
2014-05-07 16:37 ` Stephen Warren
2014-05-07 22:37 ` Christopher Freeman
2014-05-12 17:27 ` Stephen Warren
2014-05-21 6:00 ` Vinod Koul
2014-05-06 21:22 ` [PATCH v1 2/3] dma: tegra: change interrupt-related log levels Christopher Freeman
2014-05-06 21:22 ` [PATCH v1 3/3] dma: tegra: avoid int overflow for transferred count Christopher Freeman
2014-05-07 16:38 ` Stephen Warren [this message]
2014-05-07 19:15 ` Lars-Peter Clausen
2014-05-07 22:50 ` Christopher Freeman
2014-05-07 6:38 ` [PATCH v1 0/3] Tegra DMA residue improvements Lars-Peter Clausen
2014-05-07 21:27 ` Christopher Freeman
2014-05-21 5:52 ` Vinod Koul
2014-05-21 6:58 ` Lars-Peter Clausen
2014-05-21 11:06 ` Vinod Koul
2014-05-21 16:21 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A61A3.3050601@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=cfreeman@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox