From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbaEGVw7 (ORCPT ); Wed, 7 May 2014 17:52:59 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45313 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbaEGVwx (ORCPT ); Wed, 7 May 2014 17:52:53 -0400 Message-ID: <536AAB1C.6010301@ti.com> Date: Wed, 7 May 2014 16:52:28 -0500 From: Joel Fernandes User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Tony Lindgren CC: Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List Subject: Re: [PATCH 09/26] ARM: OMAP: dmtimer: Get rid of check for mem resource error References: <1398375849-6017-1-git-send-email-joelf@ti.com> <1398375849-6017-10-git-send-email-joelf@ti.com> <20140507152426.GD9502@atomide.com> In-Reply-To: <20140507152426.GD9502@atomide.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2014 10:24 AM, Tony Lindgren wrote: > * Joel Fernandes [140424 14:44]: >> The subsequent devm_ioremap_resource will catch it and print an error, let it >> be checked there. >> >> Signed-off-by: Joel Fernandes >> --- >> arch/arm/plat-omap/dmtimer.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c >> index 7e806f9..1fd30fa 100644 >> --- a/arch/arm/plat-omap/dmtimer.c >> +++ b/arch/arm/plat-omap/dmtimer.c >> @@ -810,10 +810,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev) >> } >> >> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (unlikely(!mem)) { >> - dev_err(dev, "%s: no memory resource.\n", __func__); >> - return -ENODEV; >> - } >> >> timer = devm_kzalloc(dev, sizeof(struct omap_dm_timer), GFP_KERNEL); >> if (!timer) { > > We still need to return an error here and not try to continue though. We are returning an error if mem is NULL so the redundant check is unnecessary: ... timer->io_base = devm_ioremap_resource(dev, mem); if (IS_ERR(timer->io_base)) return PTR_ERR(timer->io_base); thanks, -Joel