Re: [PATCH 0/4] DT platform device name collision fixes

Frank Rowand
2014-05-08T02:54:35Z

On 5/7/2014 3:52 PM, Frank Rowand wrote:
> On 5/7/2014 2:48 PM, Rob Herring wrote:
>> From: Rob Herring <robh@kernel.org>
>>
>> This series fixes the device naming collisions that can occur with
>> nultiple devices having the same name and non-translatable unit
>> addresses. This issue was raised in this thread[1]. I intend to merge
>> this regardless of whether or not some hierarchy in sysfs is created.
>> That is really a separate issue independent of these fixes.
>>
>> I found and fix a couple of other issues in the process of testing the
>> fix.
>>
>> Rob
>>
>> [1] https://lkml.org/lkml/2014/4/23/312
>>
>> Rob Herring (4):
>> of/selftest: add testcase for nodes with same name and address
>> of/platform: return error on of_platform_device_create_pdata failure
>> of/platform: fix device naming for non-translatable addresses
>> of: kill off of_can_translate_address
>
> My opinion is that this approach is not a good approach to solving the
> problem. It is papering over a symptom, instead of dealing with the
> root cause.
>
> But despite my opinion, you can add to patches 2-4 (I did not test
> the self-test added in patch 1):
>
> Tested-by: frowand.list@gmail.com <frank.rowand@sonymobile.com>
>
> The patches resolve the name conflict originally reported for the
> qcomm PMIC, tested on 3.15-rc1, with a bunch of out of tree
> patches.

And you can add to the 4 patches:

Reviewed-by: Frank Rowand <frank.rowand@sonymobile.com>

-Frank