From: Alexandre Courbot <acourbot@nvidia.com>
To: Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] gpio: include linux/bug.h in interface header
Date: Thu, 8 May 2014 23:58:02 +0900 [thread overview]
Message-ID: <536B9B7A.9060105@nvidia.com> (raw)
In-Reply-To: <7225229.HqAtN0I8Si@wuerfel>
On 05/08/2014 10:42 PM, Arnd Bergmann wrote:
> Today's linux-next kernel started showing build errors for the
> use of WARN_ON in linux/gpio/consumer.h:
>
> In file included from drivers/video/backlight/pwm_bl.c:13:0:
> include/linux/gpio/consumer.h: In function 'gpiod_put':
> include/linux/gpio/consumer.h:81:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
>
> It's not clear why this never happened before, but this patch
> fixes it by including the header that contains the defintion
> of this macro.
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
I guess this went unnoticed because this part of the code is only active
if compiled without gpiolib, which is not a very common configuration.
Sorry about that.
>
> Signed-off-by: Arnd Bergmann <arnd@arnd.de>
>
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index bed128e..073b9b1 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -1,6 +1,7 @@
> #ifndef __LINUX_GPIO_CONSUMER_H
> #define __LINUX_GPIO_CONSUMER_H
>
> +#include <linux/bug.h>
> #include <linux/err.h>
> #include <linux/kernel.h>
>
>
next prev parent reply other threads:[~2014-05-08 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:42 [PATCH] gpio: include linux/bug.h in interface header Arnd Bergmann
2014-05-08 14:58 ` Alexandre Courbot [this message]
2014-05-13 9:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B9B7A.9060105@nvidia.com \
--to=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox