* [PATCH] gpio: include linux/bug.h in interface header
@ 2014-05-08 13:42 Arnd Bergmann
2014-05-08 14:58 ` Alexandre Courbot
2014-05-13 9:25 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-05-08 13:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Alexandre Courbot, Linus Walleij
Today's linux-next kernel started showing build errors for the
use of WARN_ON in linux/gpio/consumer.h:
In file included from drivers/video/backlight/pwm_bl.c:13:0:
include/linux/gpio/consumer.h: In function 'gpiod_put':
include/linux/gpio/consumer.h:81:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
It's not clear why this never happened before, but this patch
fixes it by including the header that contains the defintion
of this macro.
Signed-off-by: Arnd Bergmann <arnd@arnd.de>
diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index bed128e..073b9b1 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -1,6 +1,7 @@
#ifndef __LINUX_GPIO_CONSUMER_H
#define __LINUX_GPIO_CONSUMER_H
+#include <linux/bug.h>
#include <linux/err.h>
#include <linux/kernel.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: include linux/bug.h in interface header
2014-05-08 13:42 [PATCH] gpio: include linux/bug.h in interface header Arnd Bergmann
@ 2014-05-08 14:58 ` Alexandre Courbot
2014-05-13 9:25 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2014-05-08 14:58 UTC (permalink / raw)
To: Arnd Bergmann, linux-kernel@vger.kernel.org; +Cc: Linus Walleij
On 05/08/2014 10:42 PM, Arnd Bergmann wrote:
> Today's linux-next kernel started showing build errors for the
> use of WARN_ON in linux/gpio/consumer.h:
>
> In file included from drivers/video/backlight/pwm_bl.c:13:0:
> include/linux/gpio/consumer.h: In function 'gpiod_put':
> include/linux/gpio/consumer.h:81:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
>
> It's not clear why this never happened before, but this patch
> fixes it by including the header that contains the defintion
> of this macro.
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
I guess this went unnoticed because this part of the code is only active
if compiled without gpiolib, which is not a very common configuration.
Sorry about that.
>
> Signed-off-by: Arnd Bergmann <arnd@arnd.de>
>
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index bed128e..073b9b1 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -1,6 +1,7 @@
> #ifndef __LINUX_GPIO_CONSUMER_H
> #define __LINUX_GPIO_CONSUMER_H
>
> +#include <linux/bug.h>
> #include <linux/err.h>
> #include <linux/kernel.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: include linux/bug.h in interface header
2014-05-08 13:42 [PATCH] gpio: include linux/bug.h in interface header Arnd Bergmann
2014-05-08 14:58 ` Alexandre Courbot
@ 2014-05-13 9:25 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-05-13 9:25 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-kernel@vger.kernel.org, Alexandre Courbot
On Thu, May 8, 2014 at 3:42 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Today's linux-next kernel started showing build errors for the
> use of WARN_ON in linux/gpio/consumer.h:
>
> In file included from drivers/video/backlight/pwm_bl.c:13:0:
> include/linux/gpio/consumer.h: In function 'gpiod_put':
> include/linux/gpio/consumer.h:81:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
>
> It's not clear why this never happened before, but this patch
> fixes it by including the header that contains the defintion
> of this macro.
>
> Signed-off-by: Arnd Bergmann <arnd@arnd.de>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 13:42 [PATCH] gpio: include linux/bug.h in interface header Arnd Bergmann
2014-05-08 14:58 ` Alexandre Courbot
2014-05-13 9:25 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox