From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754413AbaEHRvy (ORCPT ); Thu, 8 May 2014 13:51:54 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:58202 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbaEHRvw (ORCPT ); Thu, 8 May 2014 13:51:52 -0400 Message-ID: <536BC445.8080007@cogentembedded.com> Date: Thu, 08 May 2014 21:52:05 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Geert Uytterhoeven , Simon Horman , Magnus Damm , Bastian Hecht , Linux-sh list , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support References: <1399494750-31996-1-git-send-email-geert+renesas@glider.be> <1399494750-31996-2-git-send-email-geert+renesas@glider.be> <536B7FD3.5090506@cogentembedded.com> <536B8340.4010901@cogentembedded.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2014 05:21 PM, Geert Uytterhoeven wrote: >>>>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */ >>>> This property is mandatory, according to the bindings. >>> Indeed, but you cannot put anything there until the platform has CCF, as >>> mstp3_clks doesn't exist yet. >> Yes, that was the main obstacle to accepting those bindings sooner. This >> patch therefore seems somewhat premature. > My main objective is to provide working Ethernet support for Armadillo > reference now. Mine was the same (but for BOCK-W board) but DT people didn't give a damn. :-) So there's still no Ethernet support in BOCK-W DT. > The DTS already has other nodes without "clocks" properties. It means not everybody submitting the bindings had the same bad luck as me. :-) > Gr{oetje,eeting}s, > Geert WBR, Sergei