* [GIT PULL] liblockdep fixes for v3.15
@ 2014-04-03 15:12 Sasha Levin
2014-04-14 11:24 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2014-04-03 15:12 UTC (permalink / raw)
To: Ingo Molnar; +Cc: LKML
Hi Ingo,
There are two patches from liblockdep this time around:
1. There was a build breakage caused by marking a function 'asmlinkage'
in lockdep.h. Fix that by ignoring asmlinkage and visible annotations.
2. Josh Boyer mentioned that Fedora would like to include liblockdep
as a package, so we had to fix our versioning methods from being dumb
and pointless to something actually usable. So now liblockdep.so tracks
the kernel version which makes lives of distro folks much easier.
==
The following changes since commit 01d5f3b598b18a5035426c30801adf65822dbd0c:
Merge branch 'for-3.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata (2014-03-31 15:27:37 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
for you to fetch changes up to be227b45fb228adff4371b8de9e3989904209ff4:
tools/liblockdep: Add proper versioning to the shared obj (2014-04-01 11:46:10 -0400)
----------------------------------------------------------------
Sasha Levin (2):
tools/liblockdep: Ignore asmlinkage and visible
tools/liblockdep: Add proper versioning to the shared obj
tools/lib/lockdep/Makefile | 15 ++++-----------
tools/lib/lockdep/uinclude/linux/lockdep.h | 3 +++
2 files changed, 7 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] liblockdep fixes for v3.15
2014-04-03 15:12 Sasha Levin
@ 2014-04-14 11:24 ` Ingo Molnar
0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2014-04-14 11:24 UTC (permalink / raw)
To: Sasha Levin; +Cc: LKML, Peter Zijlstra, Paul E. McKenney, Thomas Gleixner
* Sasha Levin <sasha.levin@oracle.com> wrote:
> Hi Ingo,
>
> There are two patches from liblockdep this time around:
>
> 1. There was a build breakage caused by marking a function 'asmlinkage'
> in lockdep.h. Fix that by ignoring asmlinkage and visible annotations.
>
> 2. Josh Boyer mentioned that Fedora would like to include liblockdep
> as a package, so we had to fix our versioning methods from being dumb
> and pointless to something actually usable. So now liblockdep.so tracks
> the kernel version which makes lives of distro folks much easier.
>
> ==
>
> The following changes since commit 01d5f3b598b18a5035426c30801adf65822dbd0c:
>
> Merge branch 'for-3.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata (2014-03-31 15:27:37 -0700)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
>
> for you to fetch changes up to be227b45fb228adff4371b8de9e3989904209ff4:
>
> tools/liblockdep: Add proper versioning to the shared obj (2014-04-01 11:46:10 -0400)
>
> ----------------------------------------------------------------
> Sasha Levin (2):
> tools/liblockdep: Ignore asmlinkage and visible
> tools/liblockdep: Add proper versioning to the shared obj
>
> tools/lib/lockdep/Makefile | 15 ++++-----------
> tools/lib/lockdep/uinclude/linux/lockdep.h | 3 +++
> 2 files changed, 7 insertions(+), 11 deletions(-)
Pulled, thanks Sasha!
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [GIT PULL] liblockdep fixes for v3.15
@ 2014-05-08 18:04 Sasha Levin
2014-05-11 5:24 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2014-05-08 18:04 UTC (permalink / raw)
To: Ingo Molnar; +Cc: S. Lockwood-Childs, LKML
The following changes since commit d1db0eea852497762cab43b905b879dfcd3b8987:
Linux 3.15-rc3 (2014-04-27 19:29:27 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes-3.15
for you to fetch changes up to ad3b564deb91c67ff9621255307ed31da870c8f7:
tools/liblockdep: Remove all build files when doing make clean (2014-05-08 13:55:13 -0400)
----------------------------------------------------------------
S. Lockwood-Childs (1):
tools/liblockdep: Build liblockdep from tools/Makefile
Sasha Levin (1):
tools/liblockdep: Remove all build files when doing make clean
tools/Makefile | 6 ++++++
tools/lib/lockdep/Makefile | 5 ++---
2 files changed, 8 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] liblockdep fixes for v3.15
2014-05-08 18:04 [GIT PULL] liblockdep fixes for v3.15 Sasha Levin
@ 2014-05-11 5:24 ` Ingo Molnar
0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2014-05-11 5:24 UTC (permalink / raw)
To: Sasha Levin; +Cc: S. Lockwood-Childs, LKML, Peter Zijlstra
* Sasha Levin <sasha.levin@oracle.com> wrote:
> The following changes since commit d1db0eea852497762cab43b905b879dfcd3b8987:
>
> Linux 3.15-rc3 (2014-04-27 19:29:27 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes-3.15
>
> for you to fetch changes up to ad3b564deb91c67ff9621255307ed31da870c8f7:
>
> tools/liblockdep: Remove all build files when doing make clean (2014-05-08 13:55:13 -0400)
>
> ----------------------------------------------------------------
> S. Lockwood-Childs (1):
> tools/liblockdep: Build liblockdep from tools/Makefile
>
> Sasha Levin (1):
> tools/liblockdep: Remove all build files when doing make clean
>
> tools/Makefile | 6 ++++++
> tools/lib/lockdep/Makefile | 5 ++---
> 2 files changed, 8 insertions(+), 3 deletions(-)
Pulled, thanks Sasha!
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [GIT PULL] liblockdep fixes for v3.15
@ 2014-06-19 17:13 Sasha Levin
2014-06-25 5:50 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2014-06-19 17:13 UTC (permalink / raw)
To: Ingo Molnar; +Cc: LKML
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
for you to fetch changes up to b2f8bdb50a426aa104f7a57ca823589869b8da6f:
tools/liblockdep: fix comparison of a boolean value with a value of 2 (2014-06-19 13:08:10 -0400)
----------------------------------------------------------------
zhangdianfang (1):
tools/liblockdep: fix comparison of a boolean value with a value of 2
tools/lib/lockdep/preload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] liblockdep fixes for v3.15
2014-06-19 17:13 Sasha Levin
@ 2014-06-25 5:50 ` Ingo Molnar
0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2014-06-25 5:50 UTC (permalink / raw)
To: Sasha Levin; +Cc: LKML, Peter Zijlstra, Thomas Gleixner, Paul E. McKenney
* Sasha Levin <sasha.levin@oracle.com> wrote:
> The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
>
> Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
>
> for you to fetch changes up to b2f8bdb50a426aa104f7a57ca823589869b8da6f:
>
> tools/liblockdep: fix comparison of a boolean value with a value of 2 (2014-06-19 13:08:10 -0400)
>
> ----------------------------------------------------------------
> zhangdianfang (1):
> tools/liblockdep: fix comparison of a boolean value with a value of 2
>
> tools/lib/lockdep/preload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
There's a couple of problems with the commit:
- Please capitalize the first word of the title, i.e.: "tools/liblockdep: Fix ..."
- Commit b2f8bdb is committed by you, but not signed off by you. I
cannot pull SOB-less commits.
- It's not immediately obvious from the description why the change is
made, please use the customary changelog style we use in the
kernel:
" Current code does (A), this has a problem when (B).
We can improve this doing (C), because (D)."
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-25 5:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 18:04 [GIT PULL] liblockdep fixes for v3.15 Sasha Levin
2014-05-11 5:24 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2014-06-19 17:13 Sasha Levin
2014-06-25 5:50 ` Ingo Molnar
2014-04-03 15:12 Sasha Levin
2014-04-14 11:24 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox