From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: initialize struct request fields individually
Date: Thu, 8 May 2014 14:53:08 -0600 [thread overview]
Message-ID: <536BEEB4.4000404@fb.com> (raw)
In-Reply-To: <1399371165-12883-1-git-send-email-hch@lst.de>
On 05/06/2014 04:12 AM, Christoph Hellwig wrote:
> This allows us to avoid a non-atomic memset over ->atomic_flags as well
> as killing lots of duplicate initializations.
I had an earlier variant of this as well, they are quite a few fields we
can neglect to initialize. But I think this is a safe start, however,
and we can always optimize it on top of it. Perhaps even start to
separate struct request a bit, so we can safely memset parts of it easily.
prev parent reply other threads:[~2014-05-08 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 10:12 [PATCH] blk-mq: initialize struct request fields individually Christoph Hellwig
2014-05-08 20:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536BEEB4.4000404@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox