* [PATCH] sched/rt: Fix a comment in struct sched_dl_entity
@ 2014-05-08 10:31 xiaofeng.yan
2014-05-08 11:04 ` Peter Zijlstra
0 siblings, 1 reply; 4+ messages in thread
From: xiaofeng.yan @ 2014-05-08 10:31 UTC (permalink / raw)
To: linux-kernel, mingo, peterz; +Cc: xiaofeng_yan2004, xiaofeng.yan
Change sched_setscheduler2() to sched_setscheduler() in the comments.
There isn't function sched_setscheduler2() in the main line.
The previous EDF version defines this function
before being merged into the main line.
User should use sched_setscheduler() instead of
sched_setscheduler2() now.
Signed-off-by: xiaofeng.yan <xiaofeng.yan@huawei.com>
---
include/linux/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 25f54c7..fe263e7 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1123,8 +1123,8 @@ struct sched_dl_entity {
/*
* Original scheduling parameters. Copied here from sched_attr
- * during sched_setscheduler2(), they will remain the same until
- * the next sched_setscheduler2().
+ * during sched_setscheduler(), they will remain the same until
+ * the next sched_setscheduler().
*/
u64 dl_runtime; /* maximum runtime for each instance */
u64 dl_deadline; /* relative deadline of each instance */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sched/rt: Fix a comment in struct sched_dl_entity
2014-05-08 10:31 [PATCH] sched/rt: Fix a comment in struct sched_dl_entity xiaofeng.yan
@ 2014-05-08 11:04 ` Peter Zijlstra
2014-05-09 3:33 ` xiaofeng.yan
0 siblings, 1 reply; 4+ messages in thread
From: Peter Zijlstra @ 2014-05-08 11:04 UTC (permalink / raw)
To: xiaofeng.yan; +Cc: linux-kernel, mingo, xiaofeng_yan2004
On Thu, May 08, 2014 at 10:31:20AM +0000, xiaofeng.yan wrote:
> Change sched_setscheduler2() to sched_setscheduler() in the comments.
> There isn't function sched_setscheduler2() in the main line.
> The previous EDF version defines this function
> before being merged into the main line.
> User should use sched_setscheduler() instead of
> sched_setscheduler2() now.
Nah, you fail.. the interface is now called sched_setattr()
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sched/rt: Fix a comment in struct sched_dl_entity
@ 2014-05-09 3:21 xiaofeng.yan
0 siblings, 0 replies; 4+ messages in thread
From: xiaofeng.yan @ 2014-05-09 3:21 UTC (permalink / raw)
To: linux-kernel, mingo, peterz; +Cc: xiaofeng_yan2004, xiaofeng.yan
Change sched_setscheduler2() to sched_setattr() in the comments.
There isn't function sched_setscheduler2() in the main line.
The previous EDF version defines this function
before being merged into the main line.
User should use sched_setattr() instead of
sched_setscheduler2() now.
Signed-off-by: xiaofeng.yan <xiaofeng.yan@huawei.com>
---
include/linux/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 25f54c7..ed64468 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1123,8 +1123,8 @@ struct sched_dl_entity {
/*
* Original scheduling parameters. Copied here from sched_attr
- * during sched_setscheduler2(), they will remain the same until
- * the next sched_setscheduler2().
+ * during sched_setattr(), they will remain the same until
+ * the next sched_setattr().
*/
u64 dl_runtime; /* maximum runtime for each instance */
u64 dl_deadline; /* relative deadline of each instance */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sched/rt: Fix a comment in struct sched_dl_entity
2014-05-08 11:04 ` Peter Zijlstra
@ 2014-05-09 3:33 ` xiaofeng.yan
0 siblings, 0 replies; 4+ messages in thread
From: xiaofeng.yan @ 2014-05-09 3:33 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: linux-kernel, mingo, xiaofeng_yan2004
On 2014/5/8 19:04, Peter Zijlstra wrote:
> On Thu, May 08, 2014 at 10:31:20AM +0000, xiaofeng.yan wrote:
>> Change sched_setscheduler2() to sched_setscheduler() in the comments.
>> There isn't function sched_setscheduler2() in the main line.
>> The previous EDF version defines this function
>> before being merged into the main line.
>> User should use sched_setscheduler() instead of
>> sched_setscheduler2() now.
> Nah, you fail.. the interface is now called sched_setattr()
>
>
thanks for your reply. I will push new patch according to your suggest.
Thanks
xiaofeng.yan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-09 3:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 10:31 [PATCH] sched/rt: Fix a comment in struct sched_dl_entity xiaofeng.yan
2014-05-08 11:04 ` Peter Zijlstra
2014-05-09 3:33 ` xiaofeng.yan
-- strict thread matches above, loose matches on Subject: below --
2014-05-09 3:21 xiaofeng.yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox