From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Julius Werner <jwerner@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f
Date: Fri, 09 May 2014 11:07:40 +0300 [thread overview]
Message-ID: <536C8CCC.8010600@linux.intel.com> (raw)
In-Reply-To: <20140507150240.GK18465@intel.com>
>> I can't see how this relates to Julius patch though, and I'm not sure yet why it
>> only triggers when devices are connected to SS ports. Maybe just unlucky timing?
>
> I think the non-SS ports are connected to the EHCI controllers rather
> than the XHCI controllers. So that explains at least one detail. And I
> guess timing is as good an excuse as any why this gets exposed by the
> patch in question.
That's right, sometimes I forget that there exists something else than xHCI.
>
>>
>> Does this help?:
>
> Indeed it does. The machine just survived a dozen or so suspend+resume
> cycles without a hitch. The bug was 100% reproducible on this machine,
> so the fix seems solid.
>
> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
Great, a patch with your Tested-by tag pushed to my tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git for-usb-linus
-Mathias
prev parent reply other threads:[~2014-05-09 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 18:05 [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f Ville Syrjälä
2014-05-05 19:32 ` Julius Werner
2014-05-06 11:41 ` Ville Syrjälä
2014-05-07 13:48 ` Mathias Nyman
2014-05-07 15:02 ` Ville Syrjälä
2014-05-09 8:07 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C8CCC.8010600@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox