From: Alex Shi <alex.shi@linaro.org>
To: Morten Rasmussen <morten.rasmussen@arm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"efault@gmx.de" <efault@gmx.de>,
"wangyun@linux.vnet.ibm.com" <wangyun@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mgorman@suse.de" <mgorman@suse.de>
Subject: Re: [RESEND PATCH V5 0/8] remove cpu_load idx
Date: Sat, 10 May 2014 00:30:56 +0800 [thread overview]
Message-ID: <536D02C0.6070408@linaro.org> (raw)
In-Reply-To: <20140429150430.GI2639@e103034-lin>
于 4/29/14, 23:04, Morten Rasmussen 写道:
> On Thu, Apr 24, 2014 at 05:20:29PM +0100, Peter Zijlstra wrote:
>> OK, this series is a lot saner, with the exception of 3/8 and
>> dependents.
>>
>> I do still worry a bit for loosing the longer term view for the big
>> domains though. Sadly I don't have any really big machines.
>>
>> I think the entire series is equivalent to setting LB_BIAS to false. So
>> I suppose we could do that for a while and if nobody reports horrible
>> things we could just do this.
>>
>> Anybody?
> I can't say what will happen on big machines, but I think the LB_BIAS
> test could be a way to see what happens. I'm not convinced that it won't
> lead to more task migrations since we will use the instantaneous cpu
> load (weighted_cpuload()) unfiltered.
Reject a simple and partly tested solution because of a untested guess?
Even the old double bias is better in few sceanrios, it doesn't mean it
is good
in theory.
I don't know the result on big machine too. but imbalance_pct of
sched_domain
is designed for balance bias on different domain level. We should tune
that instead
of bias on an random long term load.
Before runnable avg introduction, cpu_load idx make sense on history
load tracking.
With runnable avg, big instant load means tasks had been running for
long time. so
we already counted the task history.
As to the cpu history load, if it caused by task moving to other cpu, it
isn't right to
still count their load on old cpu.
> Morten
next prev parent reply other threads:[~2014-05-09 16:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 2:43 [RESEND PATCH V5 0/8] remove cpu_load idx Alex Shi
2014-04-16 2:43 ` [PATCH V5 1/8] sched: shortcut to remove load_idx Alex Shi
2014-04-16 2:43 ` [PATCH V5 2/8] sched: remove rq->cpu_load[load_idx] array Alex Shi
2014-04-16 2:43 ` [PATCH V5 3/8] sched: remove source_load and target_load Alex Shi
2014-04-24 14:18 ` Peter Zijlstra
2014-04-16 2:43 ` [PATCH V5 4/8] sched: remove LB_BIAS Alex Shi
2014-04-16 2:43 ` [PATCH V5 5/8] sched: clean up cpu_load update Alex Shi
2014-04-16 2:43 ` [PATCH V5 6/8] sched: rewrite update_cpu_load_nohz Alex Shi
2014-04-16 2:43 ` [PATCH V5 7/8] sched: remove rq->cpu_load and rq->nr_load_updates Alex Shi
2014-04-16 2:43 ` [PATCH V5 8/8] sched: rename update_*_cpu_load Alex Shi
2014-04-24 16:20 ` [RESEND PATCH V5 0/8] remove cpu_load idx Peter Zijlstra
2014-04-29 15:04 ` Morten Rasmussen
2014-05-09 16:30 ` Alex Shi [this message]
2014-05-01 0:41 ` Alex Shi
2014-05-06 9:54 ` Preeti Murthy
2014-05-06 11:39 ` Peter Zijlstra
2014-05-08 9:10 ` Preeti U Murthy
2014-04-29 14:52 ` Morten Rasmussen
2014-04-30 9:24 ` Alex Shi
2014-05-06 8:33 ` Alex Shi
2014-05-06 11:43 ` Peter Zijlstra
2014-05-09 16:41 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536D02C0.6070408@linaro.org \
--to=alex.shi@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox