From: Dave Hansen <dave.hansen@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Gleb Natapov <gleb@redhat.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: KVM_GUEST support breaks page fault tracing
Date: Fri, 09 May 2014 09:42:25 -0700 [thread overview]
Message-ID: <536D0571.6030202@intel.com> (raw)
In-Reply-To: <20140508194508.561ed220@gandalf.local.home>
On 05/08/2014 04:45 PM, Steven Rostedt wrote:
> As your patch showed up as an attachment, I couldn't include it in my
> reply. But sure, that may work. But you could also play tricks to keep
> the overhead off when tracing is disabled like this one:
...
How important is it to have zero-overhead? This bug was introduced by
trying to do just that, and I'm worried about having an explosion of so
many paths to get in to the page fault code. The overhead in this case
is just a few noops, right?
I guess that's a question for the KVM folks. Do you guys prefer zero
overhead or simpler code?
prev parent reply other threads:[~2014-05-09 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 22:22 KVM_GUEST support breaks page fault tracing Dave Hansen
2014-05-08 22:24 ` Thomas Gleixner
2014-05-08 23:05 ` Dave Hansen
2014-05-08 23:45 ` Steven Rostedt
2014-05-09 16:42 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536D0571.6030202@intel.com \
--to=dave.hansen@intel.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox