Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

Geert Uytterhoeven
2014-05-08T13:06:04Z

Hi Sergei,

On Thu, May 8, 2014 at 3:00 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>> + ether: ethernet@e9a00000 {
>
> Are you really going to refer to this node somewhere, using its label?

Yes, from r8a7740-armadillo800eva-reference.dts

>> + compatible = "renesas,gether-r8a7740";
>> + reg = <0xe9a00000 0x800>,
>> + <0xe9a01800 0x800>;
>> + interrupt-parent = <&gic>;
>> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */
>
> This property is mandatory, according to the bindings.

Indeed, but you cannot put anything there until the platform has CCF, as
mstp3_clks doesn't exist yet.
Currently it relies on a matching CLKDEV_DEV_ID() in platform code.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds