Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

Sergei Shtylyov
2014-05-08T13:14:28Z

On 05/08/2014 05:06 PM, Geert Uytterhoeven wrote:

>>> + ether: ethernet@e9a00000 {

>> Are you really going to refer to this node somewhere, using its label?

> Yes, from r8a7740-armadillo800eva-reference.dts

Ah, I completely forgot that there should be a board specific part of the
node. Sorry.

>>> + compatible = "renesas,gether-r8a7740";
>>> + reg = <0xe9a00000 0x800>,
>>> + <0xe9a01800 0x800>;
>>> + interrupt-parent = <&gic>;
>>> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
>>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */

>> This property is mandatory, according to the bindings.

> Indeed, but you cannot put anything there until the platform has CCF, as
> mstp3_clks doesn't exist yet.

Yes, that was the main obstacle to accepting those bindings sooner. This
patch therefore seems somewhat premature.

> Gr{oetje,eeting}s,
> Geert

WBR, Sergei